Add the ability to the UI to delete engagements from the engagement tab #6514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maffooch
approved these changes
Jul 5, 2022
StefanFl
previously requested changes
Jul 13, 2022
coheigea
changed the title
coheigea
force-pushed
the
coheigea/delete_engagements
branch
2 times, most recently
from
461b4de to
e2c72ad
Compare
|
Still seeing the z-index issue here, but the menu can be scrolled to show the whole dropdown |
|
Yeah I tried and failed to find a way to display it outside of the list |
|
@blakeaowens is going to try to fix the zindex issue. |
blakeaowens
reviewed
Oct 26, 2022
blakeaowens
reviewed
Oct 26, 2022
blakeaowens
reviewed
Oct 26, 2022
blakeaowens
reviewed
Oct 26, 2022
blakeaowens
requested changes
Oct 26, 2022
coheigea
force-pushed
the
coheigea/delete_engagements
branch
from
a11291e to
cae9f5b
Compare
|
There's still a bug in active engagements, this time if you scroll down the page the 3 dots remain in situ:
|
|
@coheigea if this PR is still in progress, you can mark it as a draft. |
coheigea
changed the title
|
|
@coheigea I will have another look later this evening. |
|
|
Co-authored-by: Blake Owens <76979297+blakeaowens@users.noreply.github.com>
Co-authored-by: Blake Owens <76979297+blakeaowens@users.noreply.github.com>
Co-authored-by: Blake Owens <76979297+blakeaowens@users.noreply.github.com>
Co-authored-by: Blake Owens <76979297+blakeaowens@users.noreply.github.com>
coheigea
force-pushed
the
coheigea/delete_engagements
branch
from
0afe6db to
c0fbe91
Compare
|
LGTM thanks @blakeaowens |
blakeaowens
approved these changes
Oct 31, 2022
blakeaowens
dismissed
StefanFl’s stale review
Issue has been addressed in latest commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The products and findings tabs have three vertical dots that allow you to edit/delete/etc., however these are missing from the engagements tab. So if you go to "All Engagements" for example you can't delete an engagement.
This PR adds the three vertical dots for "All Engagements", "Active Engagements" and "Engagements by Product"