Skip to content

style: normalize sarif files (LF + trim) #12660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"text":"If a variable is not declared as a local variable, it becomes a global variable by default, which may be unintentional and could lead to unexpected behavior."
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand Down Expand Up @@ -86,7 +86,7 @@
"text":"An expression that has no effect and is used in a void context is most likely redundant and may indicate a bug."
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand All @@ -110,7 +110,7 @@
"text":"Unreachable statements are often indicative of missing code or latent bugs and should be avoided."
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand All @@ -133,7 +133,7 @@
"text":"An assignment to a local variable that is not used later on, or whose value is always overwritten, has no effect."
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand All @@ -155,7 +155,7 @@
"text":"External links that open in a new tab or window but do not specify link type 'noopener' or 'noreferrer' are a potential security risk."
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand Down Expand Up @@ -2169,7 +2169,7 @@
"text":"The return value of a procedure (a function that does not return a value) is used. This is confusing to the reader as the value (None) has no meaning."
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand Down Expand Up @@ -2215,7 +2215,7 @@
"text":"Unnecessary 'pass' statement"
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand Down Expand Up @@ -2285,7 +2285,7 @@
"text":"Assignment to a variable occurs multiple times without any intermediate use of that variable"
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand Down Expand Up @@ -2405,7 +2405,7 @@
"text":"Code is unreachable"
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand Down Expand Up @@ -2524,7 +2524,7 @@
"text":"Duplicate characters in a class have no effect and may indicate an error in the regular expression."
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand Down Expand Up @@ -2570,7 +2570,7 @@
"text":"When adding new attributes to instances of a class, equality for that class needs to be defined."
},
"defaultConfiguration":{

},
"properties":{
"tags":[
Expand Down Expand Up @@ -17890,4 +17890,4 @@
}
}
]
}
}
2 changes: 1 addition & 1 deletion unittests/scans/sarif/SuppressionTestCurrent.sarif
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,4 @@
"columnKind":"utf16CodeUnits"
}
]
}
}
2 changes: 1 addition & 1 deletion unittests/scans/sarif/appendix_k.sarif
Original file line number Diff line number Diff line change
Expand Up @@ -472,7 +472,7 @@
"message": {
"text": "Path from declaration to usage"
},

"threadFlows": [
{
"id": "thread-52",
Expand Down
2 changes: 1 addition & 1 deletion unittests/scans/sarif/appendix_k4.sarif
Original file line number Diff line number Diff line change
Expand Up @@ -470,7 +470,7 @@
"message": {
"text": "Path from declaration to usage"
},

"threadFlows": [
{
"id": "thread-52",
Expand Down
2 changes: 1 addition & 1 deletion unittests/scans/sarif/bash-report.sarif
Original file line number Diff line number Diff line change
Expand Up @@ -1345,4 +1345,4 @@
"runGuid": "fbb1392e-e657-4572-ac07-0e107d1ff3f1"
}
]
}
}
Loading