-
Notifications
You must be signed in to change notification settings - Fork 20
Add OIDC to CloudFormation template #1654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
lionello
wants to merge
17
commits into
main
Choose a base branch
from
lio/cloudformation-template
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+1,476
−291
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
03f9e17 to
fa5e835
Compare
…ion template - Introduced OIDCProvider struct in oidcprovider.go to define AWS::IAM::OIDCProvider resource. - Updated params.go to include new parameter for CI role name. - Enhanced setup.go to manage stack updates by preserving existing parameters. - Modified setup_test.go to improve testing of CloudFormation setup. - Updated template.go to integrate OIDC provider and CI role name into the CloudFormation template. - Created new testdata/template.yaml file to serve as a golden file for template validation. - Removed outdated golden.yaml file.
fa5e835 to
4a34096
Compare
4b5574b to
f25913b
Compare
7d5de73 to
639f654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked Issues
Checklist