feat: Add config option to embed stylesheets by default #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuret
requested changes
Jan 14, 2022
Comment on lines
+24
to
+29
| embed = | ||
| Keyword.get( | ||
| opts, | ||
| :embed_stylesheet, | ||
| Application.get_env(:ex_css_modules, :embed_by_default, false) | ||
| ) |
There was a problem hiding this comment.
Think we'd want to have this inside the quote block, so it can retrieve the Application.env value at runtime (to support runtime configs in pre-compiled Mix Release / Distillery apps)
There was a problem hiding this comment.
Isn't the point of the embed option to compile the stylesheet into the module?
I'm having trouble seeing how this could work at runtime short of having some sort of external cache like an agent or something 🤔
There was a problem hiding this comment.
Sorry, you're right, doesn't make much sense indeed. Been working too much on compile time vs runtime config issues lately, my head was somewhere else :P
I'll test this PR in our own app somewhere this week and will get back to you.
sn3p
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a config option to embed stylesheets by default. Useful for embedding stylesheets by default in prod but not in dev.
Fixes #68