Fix allowed-ips routing setup on linux systems #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous implementation skipped adding routes for all individual allowed IPs in the presence of a single unspecified IP address while not distinguishing between IP versions. Therefore IPv6 unspecified IP (::/0) entry in allowed ips prevented all regular IPv4 routes from being added even if unspecified IPv4 address wasn't present in the allowed-ips section.
j-chmielewski
force-pushed
the
fix-default-routes
branch
from
b3b79f9 to
7f8e06c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous implementation skipped adding routes for all individual allowed IPs in the presence of a single unspecified IP address while not distinguishing between IP versions. Therefore IPv6 unspecified IP (::/0) entry in allowed ips prevented all regular IPv4 routes from being added even if unspecified IPv4 address wasn't present in the allowed-ips section.
Related to DefGuard/defguard#1000.