Skip to content

Validate cid when call fileStorage.store #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sigoden merged 3 commits into from
Jan 10, 2022
Merged

Validate cid when call fileStorage.store #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3cb2fe8
Validate cid when call fileStorage.store
sigoden Jan 10, 2022
e29b879
remove rust-cid crate
sigoden Jan 10, 2022
76f6f2e
remove unless imports
sigoden Jan 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions pallets/storage/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,6 +352,8 @@ pub mod pallet {
UnableToDeleteFile,
/// Insufficient stash
InsufficientDeposit,
/// Invalid cid
InvalidCid,
}

#[pallet::hooks]
Expand Down Expand Up @@ -782,6 +784,7 @@ pub mod pallet {
file_size > 0 && file_size <= T::MaxFileSize::get(),
Error::<T>::InvalidFileSize
);
ensure!(is_cid(&cid), Error::<T>::InvalidCid);

if let Some(mut file) = Files::<T>::get(&cid) {
let new_reserved = fee.saturating_add(file.reserved);
Expand Down Expand Up @@ -1217,3 +1220,21 @@ fn encode_del_files(list: &Vec<FileId>) -> Vec<u8> {
}
output
}

fn is_cid(cid: &[u8]) -> bool {
let len = cid.len();
if len == 46 {
return &cid[0..2] == b"Qm" &&
cid[2..].iter().all(|x| match *x {
49..=57 | 65..=90 | 97..=122 => true,
_ => false,
})
} else if len == 59 {
return &cid[0..7] == b"bafkrei" &&
cid[7..].iter().all(|x| match *x {
49..=57 | 65..=90 | 97..=122 => true,
_ => false,
})
}
false
}
2 changes: 1 addition & 1 deletion pallets/storage/src/mock.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ pub fn change_file_byte_price(v: Balance) {
}

pub fn mock_file_id(suffix: char) -> FileId {
str2bytes(&format!("QmS9ErDVxHXRNMJRJ5i3bp1zxCZzKP8QXXNH1yeeeeeee{}", suffix))
str2bytes(&format!("QmQywLBjvLgDabmv8QZmJxxj6AqmZdGNZxCvnKh644JfF{}", suffix))
}

#[derive(Debug, Clone, Default)]
Expand Down