Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade packages, refactor report command #238

Merged
merged 10 commits into from
Feb 5, 2024
Merged

feat: upgrade packages, refactor report command #238

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
318ff26
feat: start refactoring the report command
vishnu-deepsource Feb 2, 2024
8a15f31
style: format code with Gofumpt
deepsource-autofix[bot] Feb 2, 2024
76a5069
fix: fix DSN regex to handle port numbers
vishnu-deepsource Feb 2, 2024
659daa3
style: format code with Gofumpt
deepsource-autofix[bot] Feb 2, 2024
f328236
remove transformers
vishnu-deepsource Feb 2, 2024
88634ef
fix: weird test
vishnu-deepsource Feb 2, 2024
efd09cd
fix: just spaghettifying a spaghettified test
vishnu-deepsource Feb 2, 2024
fdf021c
fix: fix vulnerabilities
vishnu-deepsource Feb 5, 2024
e175660
upgrade go version
vishnu-deepsource Feb 5, 2024
9352f32
fix: remove hardcoded values in test
vishnu-deepsource Feb 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: fix DSN regex to handle port numbers
  • Loading branch information
@vishnu-deepsource
vishnu-deepsource committed Feb 2, 2024
commit 76a5069447775d03970b65a6f5cb5c5def3445cd
2 changes: 1 addition & 1 deletion command/report/dsn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ type DSN struct {
}

func NewDSN(raw string) (*DSN, error) {
dsnPattern := regexp.MustCompile(`^(https?)://([^:@]+)@([^:/]+)`)
var dsnPattern = regexp.MustCompile(`^(https?)://([^:@]+)@([^:/]+(?:\:\d+)?)`)
matches := dsnPattern.FindStringSubmatch(raw)
if len(matches) != 4 {
return nil, ErrInvalidDSN
Expand Down
11 changes: 11 additions & 0 deletions command/report/dsn_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,17 @@ func TestNewDSN(t *testing.T) {
},
wantErr: nil,
},
{
name: "valid DSN with port",
args: args{
raw: "http://f59a44307@localhost:8081",
},
want: &DSN{
Token: "f59a44307",
Host: "localhost:8081",
Protocol: "http",
},
},
{
name: "invalid DSN no http",
args: args{
Expand Down
Loading