BUG: Line endings for evr/evl outputs; extra BOM indicator in evr file #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
scottclowe
commented
Jun 25, 2020
scottclowe
commented
- Ensure line endings in evr and evl file are always as intended (i.e. \r\n, regardless of OS)
- Fix bug with \n being automatically converted into \r\n on Windows, resulting in manual \r\n becoming \r\r\n
- Fix duplicated byte order mark in evr file
The \n was being automatically replaced with the OS-specific line ending, \r\n, resulting in our \r\n being turned into \r\r\n. This is resolved by telling the file object which line ending we want to use (on all OSes) and letting it turn \n into that ending.
Byte order marker should only appear once.
Write byte-order-markers the way they should be, as part of the encoding not a string manually prepended to the first line of the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.