[Embedding] Refactor the code of Save Ops for EmbeddingVariable. #900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lixy9474
force-pushed
the
refine_save_ops
branch
2 times, most recently
from
ff66442 to
a11c5ca
Compare
Mesilenceki
reviewed
Jul 19, 2023
| @@ -20,6 +20,7 @@ limitations under the License. | |||
| #include "tensorflow/core/framework/embedding/embedding_memory_pool.h" | |||
| #include "tensorflow/core/framework/embedding/embedding_var_restore.h" | |||
| #include "tensorflow/core/framework/embedding/filter_policy.h" | |||
| #include "tensorflow/core/framework/embedding/embedding_var_ckpt_data.h" | |||
tensorflow/core/kernels/BUILD
Outdated
| @@ -5443,7 +5443,8 @@ tf_kernel_library( | |||
|
|
|||
| tf_kernel_library( | |||
| name = "group_embedding_ops", | |||
| hdrs = ["group_embedding/group_embedding_lookup_sparse_forward_base_ops.h"], | |||
| hdrs = ["group_embedding/group_embedding_lookup_sparse_forward_base_ops.h", | |||
| mutex_lock l(*(dram_->get_mutex())); | ||
| TF_CHECK_OK(dram_->GetSnapshot(key_list, value_ptr_list)); | ||
| Status Save( | ||
| const string& tensor_name, |
| @@ -508,86 +508,6 @@ TF_CALL_GPU_NUMBER_TYPES(REGISTER_KERNELS_GPU) | |||
| #undef REGISTER_KERNELS_GPU | |||
| #endif // GOOGLE_CUDA | |||
|
|
|||
| #undef REGISTER_KERNELS_ALL | |||
There was a problem hiding this comment.
这里要不顺便改一下文件名吧，现在存放的都是restore的Op
lixy9474
force-pushed
the
refine_save_ops
branch
from
a11c5ca to
1506453
Compare
candyzone
approved these changes
Jul 20, 2023
Signed-off-by: lixy9474 <lxy268263@alibaba-inc.com>
lixy9474
force-pushed
the
refine_save_ops
branch
from
1506453 to
5fe6219
Compare
Mesilenceki
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.