Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

add the number of edge feature as a standard argument for all input GNNs #56

Merged
merged 4 commits into from
Oct 14, 2021

Conversation

manonreau
Copy link
Collaborator

No description provided.

@manonreau manonreau requested a review from NicoRenaud October 13, 2021 15:12
Copy link
Member

@NicoRenaud NicoRenaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :)

@@ -114,7 +114,7 @@ def __repr__(self):

class sGAT(torch.nn.Module):

def __init__(self, input_shape, output_shape=1):
def __init__(self, input_shape, output_shape=1, input_shape_edge=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

input_shape_edge is never used. It might be the intended behavior in which case you can ignore my comment

@manonreau manonreau merged commit 71f23cd into master Oct 14, 2021
@NicoRenaud NicoRenaud deleted the update_networks branch November 10, 2021 16:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants