Skip to content

fix: issue#44 integer overflow in usage request #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

fix: issue#44 integer overflow in usage request #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions deepl-java/src/main/java/com/deepl/api/parsing/Parser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,11 @@ public String parseErrorMessage(String json) {
return jsonObject.get(parameterName).getAsInt();
}

static @Nullable Long getAsLongOrNull(JsonObject jsonObject, String parameterName) {
if (!jsonObject.has(parameterName)) return null;
return jsonObject.get(parameterName).getAsLong();
}

static @Nullable String getAsStringOrNull(JsonObject jsonObject, String parameterName) {
if (!jsonObject.has(parameterName)) return null;
return jsonObject.get(parameterName).getAsString();
Expand Down
4 changes: 2 additions & 2 deletions deepl-java/src/main/java/com/deepl/api/parsing/UsageDeserializer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ public Usage deserialize(JsonElement json, Type typeOfT, JsonDeserializationCont
}

public static @Nullable Usage.Detail createDetail(JsonObject jsonObject, String prefix) {
Integer count = Parser.getAsIntOrNull(jsonObject, prefix + "count");
Integer limit = Parser.getAsIntOrNull(jsonObject, prefix + "limit");
Long count = Parser.getAsLongOrNull(jsonObject, prefix + "count");
Long limit = Parser.getAsLongOrNull(jsonObject, prefix + "limit");
if (count == null || limit == null) return null;
return new Usage.Detail(count, limit);
}
Expand Down