Skip to content

Conversation

@shinin-light
Copy link
Contributor

Step 3 of: https://deepcodeai.atlassian.net/browse/COL-729
(requires DeepCodeAI/product#505 && snyk/code-client#13)

  • Added telemetry configuration variables
  • Added thin ReportModule
  • Slightly refactored dependency injection through activate function
  • Added ignoreSuggestion event

NOT DONE:

  • viewSuggestion event has been defined but not implemented as we can only act upon hover or codeAction (i.e. Quick fix) events right now. The MVP request is satisfied as both configuration and telemetry pipelines are in place (@deepcodeg). After full implementation of DeepCode tab/panel, we will add custom viewSuggestion triggers and web views.

@shinin-light shinin-light requested a review from Arvi3d June 8, 2020 12:04
@Arvi3d Arvi3d merged commit 024bdab into master Jun 19, 2020
@Arvi3d Arvi3d deleted the report_suggestion_view branch June 19, 2020 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants