Make safeMode tests pass even when run alone.#74
Merged
Conversation
Ensures the HAL is initialized before running the safeMode tests because if it isn't SmartDashboard doesn't work properly and the tests fail. This is not normally seen when running all tests because other tests were initializing the HAL. Also rename some classes for clarity.
CoolSpy3
approved these changes
Apr 16, 2024
Member
CoolSpy3
left a comment
CoolSpy3
left a comment
There was a problem hiding this comment.
Looks good! I applied the same patch to SafeJoystickTest and patched the test so that it actually runs (and passes).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures the HAL is initialized before running the safeMode tests because if it isn't SmartDashboard doesn't work properly and the tests fail. This is not normally seen when running all tests because other tests were initializing the HAL.
Also rename some classes for clarity.