Merged
Conversation
CoolSpy3
changed the title
FriedLongJohns
previously approved these changes
Jun 29, 2023
Contributor
FriedLongJohns
left a comment
FriedLongJohns
left a comment
There was a problem hiding this comment.
Looks fine to me from what I can understand, as long as people know that revRobotics has code for this instead of lib199
ProfessorAtomicManiac
requested changes
Jun 29, 2023
src/main/java/org/carlmontrobotics/lib199/MotorControllerFactory.java
Outdated
Show resolved
Hide resolved
CoolSpy3
added
the
Patch
ProfessorAtomicManiac
previously approved these changes
Jul 5, 2023
CoolSpy3
dismissed stale reviews from ProfessorAtomicManiac and FriedLongJohns
via
ea18e73
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45 .