Skip to content

Safe Mode Utilities#43

Merged
CoolSpy3 merged 8 commits intomasterfrom
safe-mode
Jul 9, 2023
Merged

Safe Mode Utilities#43
CoolSpy3 merged 8 commits intomasterfrom
safe-mode

Conversation

@CoolSpy3
Copy link
Member

I figured something like this would make writing safe mode code easier to write and understand. I wanted to get some feedback before I spend another couple hours writing javadocs (Especially if you think this won't actually be that helpful).

@CoolSpy3 CoolSpy3 added the enhancement New feature or request label Jun 28, 2023
@CoolSpy3 CoolSpy3 added the Passed Testing This PR was successfully tested on a robot label Jun 28, 2023
@CoolSpy3
Copy link
Member Author

I'm labeling this has having passed testing. Keep in mind that I only tested the scaleJoystick, disableButton, and UnsafeCommand features. I believe the rest of the features in this PR are closely related and/or covered well by the JUnit tests. Let me know if you would like more on-robot testing before merging this PR. I'll also get started on writing documentation.

@CoolSpy3 CoolSpy3 requested a review from FriedLongJohns June 29, 2023 02:12
@CoolSpy3 CoolSpy3 added the Non-Breaking Change This PR will introduce new backwards-compatible functionality label Jun 30, 2023
Copy link
Contributor

@ProfessorAtomicManiac ProfessorAtomicManiac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging, it would be nice to document safe mode on the programming website and how it works so future members can use it.

@CoolSpy3 CoolSpy3 merged commit 0d9f6c4 into master Jul 9, 2023
@CoolSpy3
Copy link
Member Author

CoolSpy3 commented Jul 9, 2023

Before merging, it would be nice to document safe mode on the programming website and how it works so future members can use it.

Followed up in Mattermost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request Non-Breaking Change This PR will introduce new backwards-compatible functionality Passed Testing This PR was successfully tested on a robot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants