Conversation
brettle
approved these changes
Mar 14, 2023
Member
brettle
left a comment
brettle
left a comment
There was a problem hiding this comment.
Recommend addressing my one comment if possible, but it isn't critical.
src/main/java/org/carlmontrobotics/lib199/path/SwerveDriveInterface.java
Show resolved
Hide resolved
Member
Author
|
After I merged this, it looked like the javadoc build failed on master, so I've pushed one more commit outside of this PR that fixes those and updates the GitHub Action so that, in the future, javadoc build (but not deploy) is run on all branches (not just master). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch has basically become the defacto branch for lib199 changes this season (because they're all for drivetrain and drivetrain requires all of them) and has expanded wayyy past its original scope. At this point (despite all changes not being fully tested on the robot), my guess is that the public API will remain fairly stable, and I think it's probably best to just merge this into master and add any necessary fixes as we need them.
Notice: This PR contains breaking changes to the pathing interfaces in order to streamline their implementation.