Conversation
brettle
left a comment
There was a problem hiding this comment.
Until all projects which use the lib199 logging support are either updated to use the wpilib logging support or are no longer needed (i.e. the associated robots no longer exist), I recommend marking the classes as deprecated instead of deleting them. That will allow those other projects to continue to work unchanged while also taking advantage of any unrelated future lib199 fixes/features.
See: https://stackoverflow.com/questions/20674135/deprecated-vs-deprecated
|
Okay, I'll create a new PR to deprecate the code. |
|
I'm pretty sure that this condition is now met and we no longer have any active projects which use any of the logging classes. These have been deprecated for ~1 year and should be removed in the next major release. |
b117467 to
0ea61a0
Compare
WPILib has released its own logging API. It will likely be more efficient and better maintained than the one in lib199. As a result, the logging features present in lib199 are no longer necessary.