Skip to content

Remove logging support#23

Merged
brettle merged 3 commits intomasterfrom
remove-logging-support
May 15, 2024
Merged

Remove logging support#23
brettle merged 3 commits intomasterfrom
remove-logging-support

Conversation

@CoolSpy3
Copy link
Member

@CoolSpy3 CoolSpy3 commented May 9, 2022

WPILib has released its own logging API. It will likely be more efficient and better maintained than the one in lib199. As a result, the logging features present in lib199 are no longer necessary.

Copy link
Member

@brettle brettle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until all projects which use the lib199 logging support are either updated to use the wpilib logging support or are no longer needed (i.e. the associated robots no longer exist), I recommend marking the classes as deprecated instead of deleting them. That will allow those other projects to continue to work unchanged while also taking advantage of any unrelated future lib199 fixes/features.

See: https://stackoverflow.com/questions/20674135/deprecated-vs-deprecated

@CoolSpy3
Copy link
Member Author

CoolSpy3 commented May 9, 2022

Okay, I'll create a new PR to deprecate the code.

@CoolSpy3 CoolSpy3 closed this May 9, 2022
@CoolSpy3 CoolSpy3 mentioned this pull request May 9, 2022
@CoolSpy3 CoolSpy3 deleted the remove-logging-support branch March 21, 2023 08:11
@CoolSpy3 CoolSpy3 restored the remove-logging-support branch March 21, 2023 08:11
@CoolSpy3
Copy link
Member Author

I'm pretty sure that this condition is now met and we no longer have any active projects which use any of the logging classes. These have been deprecated for ~1 year and should be removed in the next major release.

@CoolSpy3 CoolSpy3 reopened this Jul 21, 2023
@CoolSpy3 CoolSpy3 added the Breaking Change This PR will require an increment to the lib199 major version number label Jul 21, 2023
@CoolSpy3 CoolSpy3 force-pushed the remove-logging-support branch from b117467 to 0ea61a0 Compare July 21, 2023 23:44
@brettle brettle merged commit 5be0b82 into master May 15, 2024
@brettle brettle deleted the remove-logging-support branch May 15, 2024 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Breaking Change This PR will require an increment to the lib199 major version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants