-
Notifications
You must be signed in to change notification settings - Fork 1
Closed
Description
Based on my reading of the spec, we should make the following changes:
- SparkMax[id] -> CANMotor:CANSparkMax[id] with Speed -> percentOutput and Current Draw -> motorCurrent
- SparkFlex[id] -> CANMotor:CANSparkMax[id] with Speed -> percentOutput and Current Draw -> motorCurrent
- Spark*[id]_RelativeEncoder -> CANEncoder:CANSpark*[id] with Position -> position (w/ units changed to rotations) and Velocity -> velocity (w/ units changed to rps)
- Spark*[id]_AbsoluteEncoder -> CANDutyCycle:CANSpark*[id] with Position -> position (w/ units changed to rotations)
- CANCoder[i] -> CANDutyCycle:CANCoder[id] with count -> position (w/ units changed to rotations)
- (maybe?) PlayingWithFusionTimeOfFlight[i] -> CANAIn:PlayingWithFusionTimeOfFlight[i]-rangeVoltsIsMM with range->voltage and CANAIn:PlayingWithFusionTimeOfFlight[i]-ambientLightLevelVoltsIsMcps with ambientLightLevel->voltage.
- Change other data names to camel case for consistency (e.g. "Neutral Deadband" -> neutralDeadband).
Thoughts @CoolSpy3?
I would especially like to get the units changed so that simulation code don't need to jump through hoops to undo the various calculations that lib199 then redoes.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels