Skip to content

Add landing page, fix CI failures, and update dependencies#55

Merged
DeeDee1103 merged 39 commits intodevelopfrom
main
Mar 21, 2026
Merged

Add landing page, fix CI failures, and update dependencies#55
DeeDee1103 merged 39 commits intodevelopfrom
main

Conversation

@DeeDee1103
Copy link
Copy Markdown
Owner

This pull request includes several dependency upgrades, bug fixes, and improvements to seeder methods and CI workflows across the StorageLens solution. The main changes are grouped below by theme.

Dependency Upgrades:

  • Upgraded Swashbuckle.AspNetCore from 6.6.2 to 10.1.5 in all service projects to ensure compatibility and access to the latest features. [1] [2] [3]
  • Upgraded Microsoft.EntityFrameworkCore.InMemory from 8.0.12 to 9.0.14 in all relevant service projects for improved testing support. [1] [2]
  • Updated GitHub Actions versions in workflow files for actions/checkout, actions/setup-dotnet, actions/upload-artifact, and dorny/paths-filter to their latest major versions for better security and reliability. [1] [2] [3] [4]

Seeder and CancellationToken Improvements:

  • Added a CancellationToken parameter (defaulting to default) to all seeder methods (DuplicatesSeeder, LocationsSeeder, FileInventorySeeder, ScanJobsSeeder) and ensured that it is passed to SaveChangesAsync, enabling proper cancellation support and matching delegate signatures for background initialization. [1] [2] [3] [4] [5] [6] [7] [8]

Bug Fixes and Build/CI Improvements:

  • Fixed build errors in StorageLens.Shared.Infrastructure by adding missing using directives, correcting type comparisons, and reordering switch arms to resolve unreachable patterns.
  • Updated the infra-validation GitHub workflow to use a native run: script instead of the azure/cli Docker action, ensuring the Bicep ARM output file is written to the runner filesystem and the validation check works as intended. [1] [2]

Testing and Accessibility Enhancements:

  • Added public partial class Program {} to StorageLens.Services.Locations/Program.cs to allow integration tests to reference the Program class using WebApplicationFactory<Program>. [1] [2]

Documentation:

  • Updated CHANGELOG.md with detailed entries describing all the above fixes and improvements, including new test coverage and infrastructure notes. [1] [2]

DeeDee1103 and others added 30 commits March 19, 2026 07:02
Add landing page and marketing layout with navigation
…on-in-tests

Add CorrelationIdDelegatingHandler and fix DI registration in pipeline integration tests
…uard-issues

fix: resolve all CI failures on develop branch (build, format, infra-validation)
Bumps [dorny/paths-filter](https://github.com/dorny/paths-filter) from 3 to 4.
- [Release notes](https://github.com/dorny/paths-filter/releases)
- [Changelog](https://github.com/dorny/paths-filter/blob/master/CHANGELOG.md)
- [Commits](dorny/paths-filter@v3...v4)

---
updated-dependencies:
- dependency-name: dorny/paths-filter
  dependency-version: '4'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/checkout](https://github.com/actions/checkout) from 4 to 6.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v4...v6)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: '6'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 4 to 7.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v4...v7)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-version: '7'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
---
updated-dependencies:
- dependency-name: AspNetCore.HealthChecks.SqlServer
  dependency-version: 9.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
---
updated-dependencies:
- dependency-name: coverlet.collector
  dependency-version: 8.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: coverlet.collector
  dependency-version: 8.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: coverlet.collector
  dependency-version: 8.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: coverlet.collector
  dependency-version: 8.0.1
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.TestHost
  dependency-version: 8.0.25
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
---
updated-dependencies:
- dependency-name: Microsoft.EntityFrameworkCore.InMemory
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.EntityFrameworkCore.InMemory
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.EntityFrameworkCore.InMemory
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.EntityFrameworkCore.InMemory
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.EntityFrameworkCore.InMemory
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.EntityFrameworkCore.InMemory
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.EntityFrameworkCore.InMemory
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.EntityFrameworkCore.InMemory
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.EntityFrameworkCore.InMemory
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…kCore.Relational

Bumps Microsoft.EntityFrameworkCore from 8.0.12 to 9.0.14
Bumps Microsoft.EntityFrameworkCore.Relational from 8.0.12 to 9.0.14

---
updated-dependencies:
- dependency-name: Microsoft.EntityFrameworkCore
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Microsoft.EntityFrameworkCore.Relational
  dependency-version: 9.0.14
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…ons/upload-artifact-7

ci: bump actions/upload-artifact from 4 to 7
…ns.Shared.Infrastructure/multi-b8d77ac462

deps: Bump Microsoft.EntityFrameworkCore and Microsoft.EntityFrameworkCore.Relational
…ns.Services.Duplicates/multi-119a5f5efb

deps: Bump Microsoft.EntityFrameworkCore.InMemory from 8.0.12 to 9.0.14
---
updated-dependencies:
- dependency-name: Swashbuckle.AspNetCore
  dependency-version: 10.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Swashbuckle.AspNetCore
  dependency-version: 10.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Swashbuckle.AspNetCore
  dependency-version: 10.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Swashbuckle.AspNetCore
  dependency-version: 10.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Swashbuckle.AspNetCore
  dependency-version: 10.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Swashbuckle.AspNetCore
  dependency-version: 10.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Swashbuckle.AspNetCore
  dependency-version: 10.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: Swashbuckle.AspNetCore
  dependency-version: 10.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
---
updated-dependencies:
- dependency-name: xunit
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: xunit
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: xunit
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: xunit
  dependency-version: 2.9.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…hers

Bumps Azure.Extensions.AspNetCore.Configuration.Secrets from 1.4.0 to 1.5.0
Bumps Azure.Identity to 1.18.0, 1.19.0
Bumps Azure.Security.KeyVault.Secrets from 4.7.0 to 4.9.0

---
updated-dependencies:
- dependency-name: Azure.Extensions.AspNetCore.Configuration.Secrets
  dependency-version: 1.5.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: Azure.Identity
  dependency-version: 1.18.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: Azure.Security.KeyVault.Secrets
  dependency-version: 4.9.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: Azure.Identity
  dependency-version: 1.19.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
…ns.Services.Analytics/multi-c9c4855e6e

deps: Bump Swashbuckle.AspNetCore from 6.6.2 to 10.1.5
…Lens.Shared.Infrastructure.Tests/Microsoft.AspNetCore.TestHost-8.0.25

deps: Bump Microsoft.AspNetCore.TestHost from 8.0.12 to 8.0.25
…ons/checkout-6

ci: bump actions/checkout from 4 to 6
---
updated-dependencies:
- dependency-name: xunit.runner.visualstudio
  dependency-version: 3.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: xunit.runner.visualstudio
  dependency-version: 3.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: xunit.runner.visualstudio
  dependency-version: 3.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: xunit.runner.visualstudio
  dependency-version: 3.1.5
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
Bumps [actions/setup-dotnet](https://github.com/actions/setup-dotnet) from 4 to 5.
- [Release notes](https://github.com/actions/setup-dotnet/releases)
- [Commits](actions/setup-dotnet@v4...v5)

---
updated-dependencies:
- dependency-name: actions/setup-dotnet
  dependency-version: '5'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
…ns.Shared.Infrastructure/multi-59ba4c3870

deps: Bump Azure.Extensions.AspNetCore.Configuration.Secrets and 2 others
…Lens.Integration.Tests/multi-822af1e36f

deps: Bump xunit.runner.visualstudio from 2.8.2 to 3.1.5
DeeDee1103 and others added 9 commits March 21, 2026 14:39
…Lens.Integration.Tests/multi-e295fc54e0

deps: Bump xunit from 2.9.2 to 2.9.3
---
updated-dependencies:
- dependency-name: Microsoft.AspNetCore.Mvc.Testing
  dependency-version: 8.0.25
  dependency-type: direct:production
  update-type: version-update:semver-patch
- dependency-name: Microsoft.AspNetCore.Mvc.Testing
  dependency-version: 8.0.25
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
---
updated-dependencies:
- dependency-name: FluentValidation.AspNetCore
  dependency-version: 11.3.1
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
…Lens.Integration.Tests/multi-75817b4286

deps: Bump Microsoft.AspNetCore.Mvc.Testing from 8.0.12 to 8.0.25
…ns.Shared.Infrastructure/FluentValidation.AspNetCore-11.3.1

deps: Bump FluentValidation.AspNetCore from 11.3.0 to 11.3.1
…Lens.Integration.Tests/multi-de0c30f1a3

deps: Bump coverlet.collector from 6.0.2 to 8.0.1
…ns.Shared.Infrastructure/AspNetCore.HealthChecks.SqlServer-9.0.0

deps: Bump AspNetCore.HealthChecks.SqlServer from 8.0.2 to 9.0.0
…ons/setup-dotnet-5

ci: bump actions/setup-dotnet from 4 to 5
…y/paths-filter-4

ci: bump dorny/paths-filter from 3 to 4
Copilot AI review requested due to automatic review settings March 21, 2026 18:46
@DeeDee1103 DeeDee1103 merged commit 1009b37 into develop Mar 21, 2026
6 of 8 checks passed
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates StorageLens’ dependencies/tooling and CI workflows, and includes a few build/runtime fixes (notably around infrastructure helpers and startup DB seeding) to get the solution building and validating cleanly.

Changes:

  • Upgraded multiple NuGet dependencies (Swashbuckle, EF Core InMemory, Azure SDKs, test/coverage packages) and refreshed GitHub Actions versions.
  • Improved startup seeders by adding CancellationToken support and propagating it to SaveChangesAsync.
  • Fixed/adjusted shared infrastructure code to resolve build/format issues and updated CI workflows (tests/coverage, infra validation, docs guard, code quality).

Reviewed changes

Copilot reviewed 28 out of 30 changed files in this pull request and generated 10 comments.

Show a summary per file
File Description
tests/StorageLens.Web.Tests/StorageLens.Web.Tests.csproj Updates xUnit and coverlet.collector versions for web tests.
tests/StorageLens.Shared.Infrastructure.Tests/StorageLens.Shared.Infrastructure.Tests.csproj Updates xUnit and coverlet.collector versions for infrastructure tests.
tests/StorageLens.Services.Scanner.Tests/StorageLens.Services.Scanner.Tests.csproj Updates xUnit and coverlet.collector versions for scanner tests.
tests/StorageLens.Integration.Tests/StorageLens.Integration.Tests.csproj Updates test dependencies (Mvc.Testing/EF InMemory/xUnit/coverlet).
src/StorageLens.Web/StorageLens.Web.csproj Upgrades EF Core InMemory dependency (currently introduces EF major-version skew).
src/StorageLens.Shared.Infrastructure/StorageLens.Shared.Infrastructure.csproj Upgrades EF Core + Azure SDK + health check packages (sets EF Core to 9.x).
src/StorageLens.Shared.Infrastructure/ObservabilityExtensions.cs Adds missing Microsoft.Extensions.Hosting using.
src/StorageLens.Shared.Infrastructure/HealthCheckExtensions.cs Adds missing routing using + minor formatting fixes.
src/StorageLens.Shared.Infrastructure/GlobalExceptionHandler.cs Fixes unreachable switch patterns + formatting cleanup.
src/StorageLens.Shared.Infrastructure/DistributedRateLimiter.cs Fixes metadata name comparisons (string vs MetadataName).
src/StorageLens.Shared.Infrastructure/Class1.cs Whitespace/indent formatting cleanup.
src/StorageLens.Shared.Contracts/Class1.cs Whitespace/indent formatting cleanup.
src/StorageLens.Services.Scanner/StorageLens.Services.Scanner.csproj Upgrades EF InMemory + Swashbuckle (currently introduces EF major-version skew).
src/StorageLens.Services.ScanJobs/StorageLens.Services.ScanJobs.csproj Upgrades EF InMemory + Swashbuckle (currently introduces EF major-version skew).
src/StorageLens.Services.ScanJobs/Extensions/ScanJobsSeeder.cs Adds optional CancellationToken and passes it to SaveChangesAsync.
src/StorageLens.Services.Orchestrator/StorageLens.Services.Orchestrator.csproj Upgrades EF InMemory + Swashbuckle (currently introduces EF major-version skew).
src/StorageLens.Services.Locations/StorageLens.Services.Locations.csproj Upgrades EF InMemory + Swashbuckle (currently introduces EF major-version skew).
src/StorageLens.Services.Locations/Program.cs Adds public partial class Program {} for integration testing support.
src/StorageLens.Services.Locations/Extensions/LocationsSeeder.cs Adds optional CancellationToken and passes it to SaveChangesAsync.
src/StorageLens.Services.Hashing/StorageLens.Services.Hashing.csproj Upgrades EF InMemory + Swashbuckle (currently introduces EF major-version skew).
src/StorageLens.Services.FileInventory/StorageLens.Services.FileInventory.csproj Upgrades EF InMemory + Swashbuckle (currently introduces EF major-version skew).
src/StorageLens.Services.FileInventory/Extensions/FileInventorySeeder.cs Adds optional CancellationToken and passes it to SaveChangesAsync.
src/StorageLens.Services.Duplicates/StorageLens.Services.Duplicates.csproj Upgrades EF InMemory + Swashbuckle (currently introduces EF major-version skew).
src/StorageLens.Services.Duplicates/Extensions/DuplicatesSeeder.cs Adds optional CancellationToken and passes it to SaveChangesAsync.
src/StorageLens.Services.Analytics/StorageLens.Services.Analytics.csproj Upgrades Swashbuckle (but still on EF SqlServer 8.x while Shared.Infrastructure is EF 9.x).
docs/CHANGELOG.md Documents dependency upgrades, CI fixes, seeder changes, and infra/build fixes.
.github/workflows/tests-and-coverage.yml Updates action versions for checkout/setup-dotnet/upload-artifact.
.github/workflows/infra-validation.yml Replaces azure/cli container action with native run step for Bicep build verification.
.github/workflows/docs-guard.yml Updates action versions (checkout, paths-filter).
.github/workflows/code-quality.yml Updates action versions for checkout/setup-dotnet.
Comments suppressed due to low confidence (4)

src/StorageLens.Services.Duplicates/Extensions/DuplicatesSeeder.cs:13

  • This async seeder uses a synchronous Any() call, which will execute a synchronous EF query and ignores the provided CancellationToken. Prefer AnyAsync(cancellationToken) (and add the EF Core using if needed) so the seeding path is fully async/cancellable.
    public static async Task SeedAsync(DuplicatesDbContext dbContext, CancellationToken cancellationToken = default)
    {
        if (dbContext.DuplicateGroups.Any())
        {
            return;
        }

src/StorageLens.Services.FileInventory/Extensions/FileInventorySeeder.cs:13

  • This async seeder uses a synchronous Any() call and does not use the provided CancellationToken for the existence check. Consider switching to AnyAsync(cancellationToken) so startup seeding can be cancelled cleanly and avoids blocking threads on sync EF operations.
    public static async Task SeedAsync(FileInventoryDbContext dbContext, CancellationToken cancellationToken = default)
    {
        if (dbContext.FileRecords.Any())
        {
            return;
        }

src/StorageLens.Services.ScanJobs/Extensions/ScanJobsSeeder.cs:14

  • This async seeder performs a synchronous Any() query and ignores the provided CancellationToken for the initial check. Prefer AnyAsync(cancellationToken) so the entire seeding flow is async and cancellable.
    public static async Task SeedAsync(ScanJobsDbContext dbContext, CancellationToken cancellationToken = default)
    {
        if (dbContext.ScanJobs.Any())
        {
            return;
        }

src/StorageLens.Services.Locations/Extensions/LocationsSeeder.cs:15

  • The seeder now accepts a CancellationToken, but the initial AnyAsync() call doesn’t pass it. Consider using AnyAsync(cancellationToken) so cancellation is honored consistently throughout the seeding flow.
    public static async Task SeedAsync(LocationsDbContext dbContext, CancellationToken cancellationToken = default)
    {
        if (await dbContext.StorageLocations.AnyAsync())
        {
            return;
        }

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.12" />
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EF Core packages are now mixed across major versions (InMemory 9.x with SqlServer 8.x). EF Core providers must match the EF Core runtime major version; otherwise NuGet will downgrade/float or you can hit runtime type/assembly mismatches. Align all Microsoft.EntityFrameworkCore* packages (e.g., either keep everything on 8.0.x or upgrade SqlServer to 9.0.14 as well).

Suggested change
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.14" />

Copilot uses AI. Check for mistakes.
<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.12" />
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EF Core packages are mixed across major versions (Microsoft.EntityFrameworkCore.InMemory 9.x vs Microsoft.EntityFrameworkCore.SqlServer 8.x). These need to be kept on the same major version to avoid restore/runtime issues; please align the SqlServer provider with the EF Core 9.x upgrade (or revert InMemory to 8.0.x).

Suggested change
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.14" />

Copilot uses AI. Check for mistakes.

<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EF Core packages are mixed across major versions (Microsoft.EntityFrameworkCore.InMemory 9.x vs Microsoft.EntityFrameworkCore.SqlServer 8.x). Align EF Core package versions across the project to prevent package downgrade warnings and potential runtime assembly mismatches.

Suggested change
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />

Copilot uses AI. Check for mistakes.
Comment on lines 10 to 15
<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.12" />
<PackageReference Include="Microsoft.Extensions.Http.Polly" Version="8.0.12" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="6.6.2" />
<PackageReference Include="Swashbuckle.AspNetCore" Version="10.1.5" />
</ItemGroup>
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EF Core packages are mixed across major versions (Microsoft.EntityFrameworkCore.InMemory 9.x vs Microsoft.EntityFrameworkCore.SqlServer 8.x). Providers and runtime should stay on the same major/minor line; align versions across the project (and with Shared.Infrastructure) to avoid restore/runtime conflicts.

Copilot uses AI. Check for mistakes.

<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EF Core packages are mixed across major versions (Microsoft.EntityFrameworkCore.InMemory 9.x vs Microsoft.EntityFrameworkCore.SqlServer 8.x). EF Core providers must match the EF Core runtime major version; please align versions (upgrade SqlServer to 9.x or revert InMemory to 8.x).

Suggested change
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />

Copilot uses AI. Check for mistakes.

<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EF Core packages are mixed across major versions (Microsoft.EntityFrameworkCore.InMemory 9.x vs Microsoft.EntityFrameworkCore.SqlServer 8.x). Align all EF Core packages in this project to the same major/minor version to avoid restore/runtime issues.

Suggested change
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />

Copilot uses AI. Check for mistakes.

<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EF Core packages are mixed across major versions (Microsoft.EntityFrameworkCore.InMemory 9.x vs Microsoft.EntityFrameworkCore.SqlServer 8.x). Align EF Core provider/runtime versions (either upgrade SqlServer to 9.x or revert InMemory to 8.x).

Suggested change
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />

Copilot uses AI. Check for mistakes.

<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EF Core packages are mixed across major versions (Microsoft.EntityFrameworkCore.InMemory 9.x vs Microsoft.EntityFrameworkCore.SqlServer 8.x). Please keep EF Core provider/runtime packages on the same major version to prevent restore/runtime incompatibilities.

Suggested change
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore.InMemory" Version="8.0.12" />

Copilot uses AI. Check for mistakes.
@@ -10,7 +10,7 @@
<ItemGroup>
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.12" />
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This project still references Microsoft.EntityFrameworkCore.SqlServer 8.0.12 while StorageLens.Shared.Infrastructure was upgraded to EF Core 9.x. EF Core provider/runtime packages must stay on the same major version across the dependency graph; align this package (or revert the EF Core 9.x upgrade) to avoid restore/runtime conflicts.

Suggested change
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.SqlServer" Version="9.0.0" />

Copilot uses AI. Check for mistakes.
Comment on lines +18 to +19
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.14" />
Copy link

Copilot AI Mar 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

StorageLens.Shared.Infrastructure was upgraded to EF Core 9.x. Any consuming projects still on EF Core 8.x providers (e.g., Microsoft.EntityFrameworkCore.SqlServer 8.0.12) will end up with mixed major versions in the dependency graph. Consider aligning EF Core versions across the solution (either upgrade all EF packages to 9.0.14 or keep everything on 8.0.x).

Suggested change
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="9.0.14" />
<PackageReference Include="Microsoft.EntityFrameworkCore" Version="8.0.12" />
<PackageReference Include="Microsoft.EntityFrameworkCore.Relational" Version="8.0.12" />

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants