allow more letters in identifiers #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielhdt
previously approved these changes
Nov 16, 2024
| @@ -27,7 +27,9 @@ let mk_config loc lid = | |||
| | "CBN" when !strat = None -> strat := Some ByName | |||
| | "CBV" when !strat = None -> strat := Some ByValue | |||
| | "CBSV" when !strat = None -> strat := Some ByStrongValue | |||
| | i when !nb_steps = None -> nb_steps := Some (int_of_string i) | |||
| | i when !nb_steps = None -> | |||
| let n = int_of_string i in | |||
There was a problem hiding this comment.
int_of_string can raise a Failure exception, you may want to catch it, don't you?
There was a problem hiding this comment.
Note that Failure was not specifically caught before either. It is caught a few lines later and generates a scoping error:
Dedukti/parsing/menhir_parser.mly
Line 38 in b7949df
There was a problem hiding this comment.
Do you think that we should introduce a more specific error?
There was a problem hiding this comment.
I'd say it depends if you really expect it to happen, or if it's an assert false kind of failure (but at least you want to know where it came from as a developer, if it ever happens)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main modifs are in parsing/lexer.mll and parsing/menhir_parser.mly.
Spaces are added in test files (e.g. writing A -> A instead of A->A).
The error code for tests/KO/nsteps1.dk (
#EVAL[-1]) is changed in tests/main.ml from lexing error to scoping error because '-' is now allowed in identifiers but the argument of#EVALmust be a non-negative integer.