Fix IUPAC bug #78
Merged
Fix IUPAC bug #78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannespetur
commented
Jun 1, 2021
| } | ||
| } | ||
| var.add_base_in_front(true); // Add N | ||
|
|
Member
Author
There was a problem hiding this comment.
This is the actual bugfix, rest is some clang-tidy warnings.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a rare bug encountered in
graphtyper genotype. Happens if an ambigous IUPAC base (R/W/...) occurs on the reference genome and is followed by series of SNPs are the very next base. In this case Variant::add_base_in_front() returns false and an N is added to the SNP series, but by mistake the position isn't adjusted.