Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/sg 000 add classnames to config #191

Merged
merged 3 commits into from
Sep 26, 2023
Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

Conversation

Louis-Dupont
Copy link
Contributor

@Louis-Dupont Louis-Dupont commented Sep 26, 2023

Adding class_names to the data_config.
To simplify this, the data_config was also moved to be instantiated earlier in the pipeline. Now it is instantiated in the AnalysisManager instead of being instantiated in the DatasetAdapter. This way, all the processing classes have a much simpler signature.

@Louis-Dupont Louis-Dupont marked this pull request as ready for review September 26, 2023 13:44
@Louis-Dupont Louis-Dupont merged commit 4449ded into master Sep 26, 2023
@Louis-Dupont Louis-Dupont deleted the hotfix/SG-000-add_classnames_to_config branch September 26, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

1 participant