Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: user roles management #669

Closed
wants to merge 33 commits into from
Closed

feat: user roles management #669

wants to merge 33 commits into from

Conversation

omar-chahbouni-decathlon
Copy link
Contributor

@omar-chahbouni-decathlon omar-chahbouni-decathlon commented Oct 4, 2022 •
edited
Loading

Type of modification

  • Breaking change
  • New Feature
  • Bug Fix
  • Chore (refactor, documentation, tests... all the changes with no impact on ARA functionalities.)

Changes description

Add some quick description about what your PullRequest change in
ARA's feature/behavior

Technical description

Add a quick description about what your PullRequest change in
ARA's code. (example: add a processor check in...)

PR CheckList

Please make sure your PullRequest respect all those items :

  • Your PR's title has the prefix : feat:, fix: or chore:
  • You have asked a review from one of the ARA maintainer in your PR.
  • If your PR is related to an issue, add the issue's number in it.
  • All the code you added is documented.
  • All the code you added is tested and the tests are in success.
  • You already signed the Contributor License Agreement and give us the document

@omar-chahbouni-decathlon omar-chahbouni-decathlon marked this pull request as draft October 4, 2022 09:58
@omar-chahbouni-decathlon omar-chahbouni-decathlon force-pushed the feat/user-roles-management branch 2 times, most recently from c27b44a to 66585f7 Compare October 28, 2022 13:03
@sonarqubecloud
Copy link

[ARA core-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[ARA web-ui] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

[ARA api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

87.6% 87.6% Coverage
0.0% 0.0% Duplication

@omar-chahbouni-decathlon omar-chahbouni-decathlon force-pushed the feat/user-roles-management branch 3 times, most recently from 509d7f5 to 6c5f538 Compare November 29, 2022 10:53
@omar-chahbouni-decathlon omar-chahbouni-decathlon force-pushed the feat/user-roles-management branch 2 times, most recently from f3c026c to eae5049 Compare December 15, 2022 23:42
@omar-chahbouni-decathlon omar-chahbouni-decathlon force-pushed the feat/user-roles-management branch 2 times, most recently from b56cac6 to 1d9cc26 Compare February 19, 2023 15:43
github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 22, 2023
View reviewed changes
code/api/api/src/main/java/com/decathlon/ara/security/access/SecurityConfiguration.java
Comment on lines +106 to +107
http
.csrf().disable() //NOSONAR

Check failure

Code scanning / CodeQL

Disabled Spring CSRF protection

CSRF vulnerability due to protection being disabled.
@sonarqubecloud
Copy link

[ARA core-api] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud
Copy link

[ARA web-ui] SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 12 Code Smells

0.0% 0.0% Coverage
1.7% 1.7% Duplication

@sonarqubecloud
Copy link

[ARA api] SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 3 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

72.7% 72.7% Coverage
0.8% 0.8% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@omar-chahbouni-decathlon @Vincent59