-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to 1.19.4 #22
Update to 1.19.4 #22
Conversation
Perhaps these commits should be squashed into 1 commit called "Update to 1.19.4" before they are merged to main? (to have a cleaner/more organized commit history that we can reference in case there are regressions, ect.) |
Edit: oh, actually I guess that's all in "fixed formatting issues" 0cec536. In that case, maybe squash all 1.19.4-related commits together (into "Update to 1.19.4") except for that autoformat commit? ie just turn this into 2 commits, if that's possible. Or 3 commits if you want the version bump to be separate as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed a couple things that seemed out of place; particularly using star imports (intentional?) and not registering the sound event.
src/main/java/io/github/debuggyteam/tablesaw/TableSawRecipes.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/debuggyteam/tablesaw/TableSawResourceLoader.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
No description provided.