Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 1.19.4 #22

Merged
merged 15 commits into from
Mar 20, 2023
Merged

Update to 1.19.4 #22

merged 15 commits into from
Mar 20, 2023

Conversation

woodiertexas
Copy link
Contributor

No description provided.

@woodiertexas woodiertexas requested a review from a team March 19, 2023 06:48
@xanderstuff
Copy link
Member

xanderstuff commented Mar 19, 2023

Perhaps these commits should be squashed into 1 commit called "Update to 1.19.4" before they are merged to main? (to have a cleaner/more organized commit history that we can reference in case there are regressions, ect.)

@xanderstuff
Copy link
Member

xanderstuff commented Mar 19, 2023

And I suppose it would be nice if the auto-format stuff would be in a separate, dedicated commit, but oh well.

Edit: oh, actually I guess that's all in "fixed formatting issues" 0cec536. In that case, maybe squash all 1.19.4-related commits together (into "Update to 1.19.4") except for that autoformat commit? ie just turn this into 2 commits, if that's possible. Or 3 commits if you want the version bump to be separate as well

Copy link

@Ampflower Ampflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noticed a couple things that seemed out of place; particularly using star imports (intentional?) and not registering the sound event.

Copy link

@Ampflower Ampflower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@woodiertexas woodiertexas merged commit 38989f1 into 1.19 Mar 20, 2023
@woodiertexas woodiertexas deleted the 1.19.4_update_round_2 branch March 20, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants