Full data generation + API + 1.19.4 port #16
Conversation
There was a problem hiding this comment.
This might turn mostly into "accidental revert?", so, I'll kinda cut it here.
Seems that several files were reverted to pretty old states, such as issue templates, the README and other things.
You may want to rebase or selectively revert the reverts that weren't intended and squash them.
|
Looking a bit into it, it does seem like the last merge commit erroneously reverted to the equivalent of the 1.18 branch, which seems odd; you could undo the incorrect changes done by the merge and squash it into the merge commit at least. |
|
Looks like github auto merge died, fixing |
|
And I did rebase but I had to also merge for some reason |
There was a problem hiding this comment.
Mainly the version and the package of a few classes I'm concerned with.
implements Waterloggable would be a good touch tho, if the classes that don't implement it could benefit from implementing it. There might not be a change in behaviour for the various blocks tho.
src/main/java/io/github/debuggyteam/architecture_extensions/blocks/JoistBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/debuggyteam/architecture_extensions/blocks/FencePostBlock.java
Outdated
Show resolved
Hide resolved
src/main/java/io/github/debuggyteam/architecture_extensions/resource/ResourceUtils.java
Show resolved
Hide resolved
No description provided.