Skip to content

estimate: show packages in NEW, but with a light blue color #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2025

Conversation

n-peugnet
Copy link
Contributor

@n-peugnet n-peugnet commented Jun 26, 2025

It uses an additional query from the DAK Web API to get the packages currently in NEW, but this one returns only source packages, so we have to keep into memory the name of the source packages when we get the list of all golang packages.

Maybe the name getGolangBinaries is a bit misleading now.

Closes: #283

Here is an example output:
2025-06-27-182444_427x257_scrot

@n-peugnet n-peugnet force-pushed the color-packages-in-new branch from 84e89c9 to 92d4ca2 Compare June 26, 2025 21:35
It uses an additional query from the DAK Web API to get the packages
currently in NEW, but this one returns only source packages, so we have
to keep into memory the name of the source packages when we get the list
of all golang packages.
@n-peugnet n-peugnet force-pushed the color-packages-in-new branch from 92d4ca2 to ee1f3d4 Compare June 26, 2025 21:57
By the way, refactor just a little bit the generation of the estimate
output.
@n-peugnet n-peugnet marked this pull request as ready for review June 27, 2025 16:21
@n-peugnet
Copy link
Contributor Author

n-peugnet commented Jun 27, 2025

Could maybe still be improved but it is good for review IMO.
CC @werdahias

@werdahias
Copy link

Thanks, looks very nice ! what's the best way to test this ?

@n-peugnet
Copy link
Contributor Author

what's the best way to test this ?

I would say:

git clone https://github.com/n-peugnet/dh-make-golang -b color-packages-in-new
cd dh-make-golang
go run . estimate <import-path>

@werdahias
Copy link

works perfectly on my end, can we get this merged ?

Copy link
Contributor

@ottok ottok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice addition and can help avoid a bunch of duplicate work

@n-peugnet
Copy link
Contributor Author

To be fair, these packages were previously not shown in the estimate output. So I'm not sure it will really avoid duplicated work. But it is nice too see the ongoing work.

I still think that I should probably rename the getGolangBinaries function and related variables to something like getDebianPackages or something like this.

@ottok
Copy link
Contributor

ottok commented Jul 27, 2025

There hasn't been any objections since I approved this, so proceeding to merge it.

@ottok ottok merged commit f94c626 into Debian:master Jul 27, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] show packages in NEW
3 participants