GEDCOM specification compliance: DatePeriod and Date #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gedcom7/grammar.py
Outdated
| stdtag = f'{ucletter}({tagchar})*' | ||
| month = f'({stdtag}|{exttag})' | ||
| dateperiodstart = f'FROM' | ||
| dateperiodend = f'TO' |
Owner
There was a problem hiding this comment.
The two lines above don't need to be f-strings
Contributor
Author
There was a problem hiding this comment.
Yes, you are right. While looking a bit deeper into the GEDCOM specification I wonder, if this point was already addressed partly by defining dateRestrict, which is not used anywhere in the rest of the specification. Thus it would be:
dateRestrict = '(FROM|TO|BET|AND|BEF|AFT|ABT|CAL|EST|BCE)"
month = f'(?!{dateRestrict})({stdtag}|{exttag})'
I submitted the question to gedcom-L, the german mailing list for GEDCOM specification. I suggest to wait for the reaction.
Contributor
Author
|
update: adjust daterestrict to reflect recent change in GEDCOM7 |
Owner
|
Thanks, perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow incomplete Dates (without day or month), especially in DatePeriods. Issue #2