Skip to content

Reimplement cached_property as a slot wrapping descriptor #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
DavidCEllis merged 12 commits into from
Dec 6, 2025
Merged

Reimplement cached_property as a slot wrapping descriptor #76

DavidCEllis merged 12 commits into from
Dec 6, 2025

Conversation

@DavidCEllis
Copy link
Owner

@DavidCEllis DavidCEllis commented Dec 5, 2025

This changes how SlotMakerMeta handles cached properties.

  • No longer creates a __dict__
  • Adds _SlottedCachedProperty, a descriptor that wraps both the slot descriptor and the function wrapped by cached_property
  • Slots are created for @cached_property fields in order to be wrapped by _SlottedCachedProperty

@DavidCEllis
Experimentally implement cached_property for slotted classes with a n…
759e573 
…ew descriptor that wraps both the slot and the function
@DavidCEllis
Performance test for unslotted metaclass prefabs
8a1beb3
@DavidCEllis
Add a check for cached_property overwriting a field
ff9c410 
get_* functions now raise TypeError instead of passing KeyError through
@DavidCEllis
get_flags can no longer raise KeyError
797c3f2
@DavidCEllis
Tests for overriding attributes and regular properties
78aaf01
@DavidCEllis
Don't do tests, even dataclasses doesn't check this - can always add …
212d6ce 
…if necessary
@DavidCEllis
test regular property over cached also works.
6884843
@DavidCEllis
use functools.update_wrapper to update the property wrapper to includ…
a576408 
…e docs and other features of the wrapped property
@DavidCEllis
formaatting
b891618
@DavidCEllis
Add tricks to handle annotations on instances
0e48bec
@DavidCEllis
Don't bother with annotations, functools doesn't
acebf65
@DavidCEllis
Only wrap the same attributes that cached_property wraps
599f8a4
@DavidCEllis DavidCEllis merged commit 4c05709 into main Dec 6, 2025
7 checks passed
@DavidCEllis DavidCEllis deleted the cached-property-alternate branch December 6, 2025 16:13
@DavidCEllis DavidCEllis mentioned this pull request Dec 6, 2025
Open
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DavidCEllis