Use textContent instead of innerHTML#108
Open
theboolean wants to merge 1 commit intoDavid-Mulder:masterfrom
Open
Use textContent instead of innerHTML#108theboolean wants to merge 1 commit intoDavid-Mulder:masterfrom
theboolean wants to merge 1 commit intoDavid-Mulder:masterfrom
Conversation
Using textContent will avoid the possibility of cross site scripting and HTML injection
Author
|
@David-Mulder any news about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
innerHTMLwill expose the library to the possibility of cross site scripting and HTML injection,textContentwill instead use string passed as-is without parsing it as HTML.Note that
textContentis the default behaviour of polymer.cc @leogr that helped me discovering and fixing this issue.