version 0.1.6 #115

David-Haim · 2023-03-17T16:27:53Z

memory leak fixes
CI/CD overhaul
use stdlibc++ on linux by default
library to properly export symbols when used from a shared-library
async_condition_variable implementation
interrupted_task as a base class for runtime_shutdown and broken_task
readme improvements

* Add CLion ignores * Use Modern CMake * Restructure the project files * Move test files around * Remove Unnecessary CMakeLists.txt * Restructure the examples * Move thread sanitizer tests to the test directory * Put coroutine options in a separate CMake module * Rewrite the example lists files * Add the option to build the library with thread sanitizer (This only works when the compiler is Clang based.) * Rewrite the sandbox lists file * Add coroutine options to tests as well * Make the add_test function forward properties * Stop script execution early to reduce indentation * Include coroutine options using a relative path Remembering to always pass the CMAKE_MODULE_PATH for every cmake invocation might become troublesome otherwise. Co-authored-by: friendlyanon <friendlyanon@users.noreply.github.com>

* Run clang-format * Missing <algorithm> header * Rework the test folder * Fix include paths in library and example code * Add a lists file that builds all the examples * Rework coroutineOptions.cmake * Fix ignores for CLion * Add CI support There are 4 builds in CI, on 2 providers: Github Actions: * Ubuntu Bionic, Clang 10, with TSAN * Ubuntu Bionic, Clang 10, without TSAN * Windows, VS2019 Travis CI: * macOS, Xcode 10.3 * Allow failures in the Travis CI * Add missing newlines at EOF Co-authored-by: friendlyanon <friendlyanon@users.noreply.github.com>

* fix include path in the sandbox and tests

* Simplify CI process (Remove Travis.ci, move macOS steps to github actions) Co-authored-by: friendlyanon <friendlyanon@users.noreply.github.com>

* Modify the imported target directly * Use a single variable for TSAN Co-authored-by: friendlyanon <friendlyanon@users.noreply.github.com>

* clang-format fine tuning

* better readme, fix include path in examples

* Make TSAN compile correctly by adding missing cmake properties * remove buggish assert from thread-pool test * compile everything in release mode with debug info

* result_core refactor * renamed to result_state * broken to consumer_context and producer_context * await_via behaviuor fine tune - resolve_via throws executor_exception if the coroutine is supended and enqueueing its resumption throws * await/await_via/resolve/resolve_via tests were re-written

* task object replaces raw usage of std::coroutine_handle * calls to executor::post try to inline the memory by using the task inline buffer (the callable doesn't run as a coroutine anymore) * await(_via)/relove(_via) throw concurrencpp::broken_task if the executor destroyed the associated task, for example, by throwing * await small refactor

* complete executors-refactor * timer::cancel also cancels scheduled-not-executed tasks, ongoing tasks are uneffected * test utils refactor * complete tests-re-write

* support shared_result objects

* result_state and result_coro_promise were merged together (finally!) * thread sanitizer tests were rewritten * small improvements and bug fixes

Co-authored-by: NN <NN---@users.noreply.github.com>

* timer queue idling mechanism * unified shutdown exception * test folder cleaning up * clang format changes * optimizations

…into develop

This fixes building with libstdc++.

* Add Clang 15 to CI * Catch exceptions by const-ref Co-authored-by: chausner <chausner@users.noreply.github.com>

@ohanar

thanks @ohanar for the discovery

* Make libc++ optional Co-authored-by: chausner <chausner@users.noreply.github.com>

* export symbols

* add a lot more build configurations to the ci Co-authored-by: David-Haim <dhayim1@gmail.com>

* load build matrix from json file

* async_condition_variable implementation

* replace details::wait_context with std::binary_semaphore

) Co-authored-by: Mathias Eggert <mathias.eggert@nordsec.com>

David-Haim · 2023-03-17T16:30:45Z

@ohanar
Hi there! long time :)
It's finally the time to release all the changes we've added in the last few months.
As you can see, the TSAN tests are failing to compile for some reason.
Can you please take a look at it? nothing has really changed since we've merged those changes to develop.. :/

ohanar · 2023-03-18T21:48:50Z

Hmm, it looks like libclang-rt is not being installed.

Adding "libclang-rt-${version}-dev" to https://github.com/David-Haim/concurrencpp/blob/develop/.github/actions/fetch-clang/action.yml#L42 should fix it, but I'm not sure if there was a change in packaging between versions (like with libunwind).

David-Haim · 2023-03-19T14:25:12Z

@ohanar
It seems like there's no such package, tried to apply the patch here

ohanar · 2023-03-20T17:54:26Z

It looks like it is as I suspected, they changed the packaging like libunwind. In this case between versions 13 and 14. Instead of universally adding the package, you could add it conditionally like libunwind with

if (${version} -ge 14) {
    $pkgs += "libclang-rt-${version}-dev"
}

* install clang-tsan manually

friendlyanon and others added 30 commits October 2, 2020 11:48

fix include path in the sandbox and tests (#17)

b67c214

* fix include path in the sandbox and tests

Simplify CI process (#18)

b496ae2

* Simplify CI process (Remove Travis.ci, move macOS steps to github actions) Co-authored-by: friendlyanon <friendlyanon@users.noreply.github.com>

Simplify test lists (#19)

4e08bff

* Modify the imported target directly * Use a single variable for TSAN Co-authored-by: friendlyanon <friendlyanon@users.noreply.github.com>

clang-format fine tuning (#20)

5c04acd

* clang-format fine tuning

Readme refactor (#21)

4ee5321

* better readme, fix include path in examples

threadpool test fine tune

ee5a635

* Make TSAN compile correctly by adding missing cmake properties * remove buggish assert from thread-pool test * compile everything in release mode with debug info

revert test cmake to b496ae2 (#28)

bb3edaf

CI/CD - no xcode version is actively selected (#31)

d9bb70e

version bump + clang format

1131140

* move to standard coroutines on MSVC

0057297

* complete executors-refactor * timer::cancel also cancels scheduled-not-executed tasks, ongoing tasks are uneffected * test utils refactor * complete tests-re-write

improvements and small fixes to 0057297

db46fc7

bump version to 0.0.9

e7dc976

Readme improvements, introduction of the task object

df560cc

Merge branch 'master' into develop

8aaa0ce

Merge remote-tracking branch 'origin/master' into develop

e23e9b3

Shared results (#37)

9954189

* support shared_result objects

* shared_result refactor

ad4dbee

* result_state and result_coro_promise were merged together (finally!) * thread sanitizer tests were rewritten * small improvements and bug fixes

bump version

68c89f6

shared_result + executor API were added to the README

5afa334

Merge remote-tracking branch 'origin/master' into develop

679173a

Use explicit bool operator. (#38)

f65caad

Co-authored-by: NN <NN---@users.noreply.github.com>

* full move to ctest

9661db5

* timer queue idling mechanism * unified shutdown exception * test folder cleaning up * clang format changes * optimizations

Merge branch 'develop' of https://github.com/David-Haim/concurrencpp …

e9743fc

…into develop

version bump

f5634fd

CI/CD: install clang 11 on ubuntu manually

5f13455

Run all tests serially

3c10fb1

David-Haim and others added 24 commits September 23, 2022 15:31

update readme

f3ad6bc

update readme #2

1aca90f

update readme #3

dc92896

update readme #4

2f8b18d

Merge remote-tracking branch 'origin' into develop

6cefce3

add algorithm include for std::sort (#89)

40c27bb

This fixes building with libstdc++.

properly deallocate heap allocated callables (#87)

b750c68

Add Clang 15 to CI, catch exceptions by const-ref (#90)

741034a

* Add Clang 15 to CI * Catch exceptions by const-ref Co-authored-by: chausner <chausner@users.noreply.github.com>

fix result_promise memory leak if get_result is not called

fcd843b

thanks @ohanar for the discovery

Use standard stdlib by default, make libc++ optional (#91)

8d03f11

* Make libc++ optional Co-authored-by: chausner <chausner@users.noreply.github.com>

Properly handle exporting symbols (#94)

53dfb24

* export symbols

return parallel coroutine with executor ptr

c83b054

Add many more build configurations to the ci (#95)

76fc077

* add a lot more build configurations to the ci Co-authored-by: David-Haim <dhayim1@gmail.com>

Ci config from json (#102)

1f58e83

* load build matrix from json file

simplify bulk_xxx mehcanism (#103)

2a578af

remove polyfill for std::binary_semaphore (#104)

3dc17b0

remove configurations where tsan=true && shared=true (#105)

fe8003a

async_condition_variable implementation (#106)

d243136

* async_condition_variable implementation

Replace details::wait_context with std::binary_semaphore (#107)

afc046f

* replace details::wait_context with std::binary_semaphore

typo fix, formatting

3c57f26

add interrupted_task for grouping broken_taks and runtime_shutdown (#111

a13af5a

) Co-authored-by: Mathias Eggert <mathias.eggert@nordsec.com>

version bump

6e954fd

readme update

de2f790

add a note about interrupted_task in the termination section

d8ce869

fix clang-tsan (#117)

6bea7a7

* install clang-tsan manually

David-Haim merged commit 944a65f into master Mar 21, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

version 0.1.6 #115

version 0.1.6 #115

Uh oh!

David-Haim commented Mar 17, 2023

Uh oh!

David-Haim commented Mar 17, 2023

Uh oh!

ohanar commented Mar 18, 2023

Uh oh!

David-Haim commented Mar 19, 2023 •

edited

Loading

Uh oh!

ohanar commented Mar 20, 2023

Uh oh!

Uh oh!

version 0.1.6 #115

version 0.1.6 #115

Uh oh!

Conversation

David-Haim commented Mar 17, 2023

Uh oh!

David-Haim commented Mar 17, 2023

Uh oh!

ohanar commented Mar 18, 2023

Uh oh!

David-Haim commented Mar 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ohanar commented Mar 20, 2023

Uh oh!

Uh oh!

David-Haim commented Mar 19, 2023 •

edited

Loading