Clang warnings #304
Closed
Clang warnings #304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
The warnings in Unity are better fixed in Unity itself. I fixed some of those in the past, but haven't found the time to do it again since then. I already disabled |
FSMaxB
reviewed
Oct 10, 2018
| list(APPEND custom_compiler_flags | ||
| -std=c89 | ||
| -pedantic | ||
| -Weverything |
Collaborator
There was a problem hiding this comment.
-Weverything is not something I'm willing to put in there. I use it from time to time in order to find new warnings that I can use though.
Collaborator
|
I'm closing this because this should be fixed upstream. |
meetrp
pushed a commit
to meetrp/cJSON
that referenced
this pull request
Oct 13, 2018
287e076 Post release 774da10 Merge pull request DaveGamble#296 from jlindgren90/master 629b86d Merge unity_setup.h into unity.h. 0914d80 Merge pull request DaveGamble#308 from codehearts/patch-1 5ee55fe Fix missing TEST_ASSERT_EACH_EQUAL_HEX_MESSAGE 38c387b Merge pull request DaveGamble#304 from VLambret/master 17d4ea9 Color test results using ANSI escape codes 031b1ba Merge pull request DaveGamble#300 from jsalling/bugfix/greater-than df78aad Make weak symbol usage more portable: a7e8797 Fix link errors with MinGW. 94a3008 Update continuous integration to build 32-bit Unity b119919 Add 64-bit comparison asserts 91bcbe1 Add 'greater/less or equal to' asserts on integers 8caade7 Fix bug in greater/less than asserts on unsigned int 1381a1a Update documentation. 2593c31 Allow suiteSetUp() and suiteTearDown() to be provided as normal C functions. 60def10 Update configuration docs git-subtree-dir: tests/unity git-subtree-split: 287e076962ec711cd2bdf08364a8df9ce51e106b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor cleanup of some clang warnings in unity.c and clang CMake warning settings.