Support default __stdcall calling convention (/Gz) on Windows #295
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This fixes this issue. |
Collaborator
|
Tanks for looking into this and taking the time to fix this issue, and sorry for taking so long to respond. |
FSMaxB
reviewed
Sep 1, 2018
Contributor
Author
|
I added two more commits. The first commit, ad2cb5b, fixes up build issues on Windows. I ensured that all projects build and all tests pass with Visual Studio 2015. The second commit, f25b844, fixed up issues specific to adding the /Gz flag. I ensured that all projects build and all tests pass with that flag on Windows as well. |
FSMaxB
reviewed
Sep 15, 2018
Collaborator
|
Thanks a lot again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds and tests pass on both Linux and Windows