Fix "missing function" exception by replacing "set_settings" calls with "set_setting" calls #1
Conversation
… set_setting calls
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @FluffySpectre, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue where the set_settings method was causing exceptions in Godot on MacOS. The author, FluffySpectre, has replaced all instances of set_settings with set_setting, resolving the compatibility problem. The changes were tested on Godot 4.3 and 4.4 RC3 on MacOS.
Highlights
- Bug Fix: Replaces
set_settingswithset_settingto avoid exceptions on MacOS. - Compatibility: Ensures the plugin works correctly on Godot 4.3 and 4.4 RC3 on MacOS.
Changelog
- addons/diff-margin/plugin.gd
- Replaced all occurrences of
editor_settings.set_settingswitheditor_settings.set_settingon lines 33, 36, 39, 42, and 45.
- Replaced all occurrences of
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Trivia time!
What is the primary use case for the Godot Engine?
Click here for the answer
The Godot Engine is primarily used for developing 2D and 3D games.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request addresses an issue where the set_settings method was not available, causing the plugin to fail on MacOS. The change replaces all occurrences of set_settings with set_setting, resolving the problem. The author has tested the fix on Godot 4.3 and 4.4 RC3 on MacOS.
Merge Readiness
The pull request appears to correctly address the reported issue. Given the author's testing and the straightforward nature of the fix, the changes seem appropriate for merging. However, since I am unable to directly approve the pull request, it is recommended that other reviewers also examine the changes before merging. There are no comments to block merging.
I couldn’t get the plugin to work in Godot on MacOS because the set_settings method is not available. I replaced all occurrences with set_setting, and now it works.
Tested with Godot 4.3 and 4.4 RC3 on MacOS.