fix: allow normal input on editables when keys overlap with map inter…#365
Merged
warm-coolguy merged 6 commits intomainfrom Sep 25, 2025
Merged
Conversation
warm-coolguy
requested review from
czirkelbach,
dopenguin and
oeninghe-dataport
as code owners
apply suggestion "remove optional filename extension" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
apply suggestion "revert version to unpublished" Co-authored-by: Pascal Röhling <73653210+dopenguin@users.noreply.github.com>
…tps://github.com/Dataport/polar into fix/prevent-normal-input-prevention-on-editables
Member
Author
warm-coolguy
deleted the
fix/prevent-normal-input-prevention-on-editables
branch
dopenguin
added a commit
that referenced
this pull request
Dec 5, 2025
… interactions Fix introduced in #365. Co-authored-by: Dennis Sen <dennis.sen@dataport.de>
dopenguin
added a commit
that referenced
this pull request
Dec 5, 2025
Fix introduced in #365. Co-authored-by: Dennis Sen <dennis.sen@dataport.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, OL keyboard interactions would prevent the handling of "+", "-", and the ArrowKeys by editable elements like
<input>. This has now been resolved.Instructions for local reproduction and review
To test, check whether the input elements in the Snowbox now accept ArrowUp, ArrowRight, ArrowDown, and ArrowLeft as regular inputs to move the cursor within the entered text, and + and - keys now result in those characters appearing instead of using them to zoom. At the same time, all of these inputs shall result in the usual map panning and zooming when the map itself is focused.
Please verify functionality on Safari Desktop.
Pull Request Checklist (for Assignee)