fix(core): initialize services earlier to ensure the map has been created for plugins by dopenguin · Pull Request #364 · Dataport/polar

dopenguin · 2025-09-23T11:41:53Z

Summary

The map may not have been initialized if the services weren't fully received from a remote source when a plugin has been added.

Instructions for local reproduction and review

Change map in mainStore to null.
Call e.g. coreStore.map.getLayers() in setupPlugin of fullscreen and log the result
No error should occur

…ated for plugins The map may not have been initialized if the services weren't fully received from a remote source when a plugin has been added.

warm-coolguy

🏓 @dopenguin
🏓 @oeninghe-dataport I made a comment requesting your feedback, too.

M-M-M-MULTIBALL.

warm-coolguy · 2025-09-26T06:11:58Z

src/core/components/PolarMap.ce.vue

 const overlay = useTemplateRef<typeof PolarMapOverlay>('polar-map-overlay')

-let map: Map | null = null
+let map: Map = {} as Map


@oeninghe-dataport This is a workaround to avoid null checks later on in all plugins. It is assumed and/or planned that, before anything else gets their turn, createMap is run and completed. So effectively, nothing will ever run into an uninitialized map, except for the first call to createMap itself.

It still is an object rather than a real new Map() so errors regarding this are more apparent. What's your feedback on this?

I agree, this really simplifies the code. Again, as #356 changes a lot here, I integrated this there -> 725b14b

warm-coolguy · 2025-09-26T06:34:29Z

examples/iceberg/App.vue

 const map = useTemplateRef('map')

-createMap(
+await createMap(


I am having trouble imagining how this works. I've checked the code in the snowbox, too, and apparently createMap and addPlugin calls can be made fully independant of each other. This is especially troubling me since I do not understand in which map the added plugin will end up in, and how to control and direct that behaviour.

I'd have expected a return value to createMap that is required to either run addPlugin with as a parameter, or that addPlugin is registered on, id est:

const polarInstance = await createMap() // addPlugin on instance polarInstanceaddPlugin(...) // XOR addPlugin requires instance as parameter addPlugin(polarInstance, ...)

The way it is currently written, I could just

createMap() addPlugin() addPlugin() addPlugin() createMap() addPlugin()

without await (since nothing is actively forcing me to await except for the following errors, if they occur ...) and be none the wiser what I have actually done. (I also tried to just randomly call addPlugin before createMap, but that fails internally due to pinia not being initialized.)

Maybe I'm missing the idea here?

In the state of this branch, all plugins are added to the same store. createMap effectively works on the same store. #356 tackles that.

However, your expectation seems to go a way that seems valid, even though it is a doubled effort.

@oeninghe-dataport Due to the possibly duplicate effort I'd like your take on this detail, too. If this is already handled, we may as well close this thread. May need a ☎️ to resolve this quickly.

@warm-coolguy I think your expectation is handled in #356 ; have a look at

polar/examples/snowbox/index.js

Line 63 in 952e614

const map = await createMap(

and

polar/examples/snowbox/index.js

Line 173 in 952e614

addPlugin(

As this changes heavily with #356, I integrated this changes there. -> e0f3b57

oeninghe-dataport

🏓 @dopenguin @warm-coolguy

oeninghe-dataport · 2025-10-01T11:16:27Z

examples/iceberg/App.vue

 const map = useTemplateRef('map')

-createMap(
+await createMap(


@warm-coolguy I think your expectation is handled in #356 ; have a look at

polar/examples/snowbox/index.js

Line 63 in 952e614

const map = await createMap(

and

polar/examples/snowbox/index.js

Line 173 in 952e614

addPlugin(

oeninghe-dataport · 2025-10-01T11:17:16Z

examples/iceberg/App.vue

 const map = useTemplateRef('map')

-createMap(
+await createMap(


As this changes heavily with #356, I integrated this changes there. -> e0f3b57

oeninghe-dataport · 2025-10-01T11:19:09Z

src/core/components/PolarMap.ce.vue

 const overlay = useTemplateRef<typeof PolarMapOverlay>('polar-map-overlay')

-let map: Map | null = null
+let map: Map = {} as Map


I agree, this really simplifies the code. Again, as #356 changes a lot here, I integrated this there -> 725b14b

oeninghe-dataport · 2025-10-01T11:23:09Z

src/core/index.ts

+			if (coreStore.configuration.checkServiceAvailability) {
+				checkServiceAvailability(coreStore.configuration, serviceRegister)
+			}


@dopenguin Is there a compelling reason to move this here? As I incorporated the changes from this PR into #356, I stumbled on this, as configureApp doesn't know the configuration anymore.

Moved this here so it is called earlier than before. Nothing really relevant

warm-coolguy

🏓 @dopenguin @oeninghe-dataport Since the conceptional stuff seems to be resolved, more is up to you two guys getting this mergable/merged. I approve as far as my concerns go.

dopenguin · 2025-10-06T07:43:14Z

Relevant changes have been integrated into #356, closing this PR.

fix(core): initialize services earlier to ensure the map has been cre…

3b9d738

…ated for plugins The map may not have been initialized if the services weren't fully received from a remote source when a plugin has been added.

dopenguin self-assigned this Sep 23, 2025

dopenguin requested review from oeninghe-dataport and warm-coolguy as code owners September 23, 2025 11:41

dopenguin added the bug Something isn't working label Sep 23, 2025

dopenguin mentioned this pull request Sep 23, 2025

feat(plugins/layerChooser): migrate plugin #358

Merged

dopenguin added this to the POLAR@3 milestone Sep 23, 2025

warm-coolguy requested changes Sep 26, 2025

View reviewed changes

Merge branch 'next' into vue3/fix-map-creation

f95b5f5

oeninghe-dataport requested changes Oct 1, 2025

View reviewed changes

warm-coolguy approved these changes Oct 6, 2025

View reviewed changes

dopenguin closed this Oct 6, 2025

dopenguin deleted the vue3/fix-map-creation branch October 29, 2025 07:49

Conversation

dopenguin commented Sep 23, 2025

Summary

Instructions for local reproduction and review

Uh oh!

warm-coolguy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

warm-coolguy Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dopenguin Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

oeninghe-dataport left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

warm-coolguy left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dopenguin commented Oct 6, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

warm-coolguy left a comment •

edited

Loading

warm-coolguy Sep 26, 2025 •

edited

Loading

dopenguin Sep 26, 2025 •

edited

Loading

warm-coolguy left a comment •

edited

Loading