Fix issue with username lookup for comments from deleted accounts #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignoring the whitespace changes I added to put my commit in line with how the latest commits seem to be formatted, this only adds a fallback lookup to the translated value 'deleted' IFF trying to lookup a username for a comment, but the user does not exist (or doesn't have a login) anymore.
This fixes a PHP whoops exception that stops InteractiveVideo objects from being opened when there are comments from deleted accounts.
To test and reproduce
-> Throws exception about failed array key lookup (original) matching line 363
Potential Improvements