-
Notifications
You must be signed in to change notification settings - Fork 67
truncate_option
to allow CASCADE mode alongside the default RESTRICT
#118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
truncate_option
to allow CASCADE mode alongside the default RESTRICT
#118
Conversation
@etagwerker This PR also fixes my issue upgrading to Rails 7.1, but this one has passing tests. Please merge as soon as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pat Looks good, thanks!
We have a gem that has an unconstrained dependency on
Seems like maybe some call sites were missed when changing the method signature in this PR? |
This is largely the hard work of @theGeorgous in #99, alongside the initiative of @nnishimura in #115 to rebase. I've added a couple of tests and ensured the argument is being passed through correctly.
Please attribute credit to @thegeorgeous - I just jumped in with these tweaks to help ensure it can be merged in as easily as possible.