Refined precision detection #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thiemowmde
added a commit
to wmde/DataValuesJavaScript
that referenced
this pull request
Nov 6, 2014
Decreased constant, see DataValues/Geo#29.
Protip: make two commits, then we can look at the diff for each (even if its one PR) |
|
Just some PS: Did it, it's two commits now. |
thiemowmde
force-pushed
the
detection
branch
from
d8bfeb4 to
a917041
Compare
thiemowmde
force-pushed
the
detection
branch
from
a917041 to
c24749e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff looks big because I renamed variables, made stuff private and reduced code duplication.
The main change is: The precision detection stops at a certain precision. Now there is a lower boundary, given by a maximum number of decimal places (after the comma). 8 for floats, 4 for DM/DMS (plus 2 places for the minutes and 2 for the seconds is also 8).
Reason for all this is IEEE. Some combinations of degrees and minutes turn into numbers like 1.20000000000001 and cause the detectors to return way to high precisions.
Bug: 64820