fix deprecation error with elastic search client and tqdm#102
Open
1mustyz wants to merge 1 commit intoDataTalksClub:mainfrom
Open
fix deprecation error with elastic search client and tqdm#1021mustyz wants to merge 1 commit intoDataTalksClub:mainfrom
1mustyz wants to merge 1 commit intoDataTalksClub:mainfrom
Conversation
Member
|
There are many changes that are not relevant to the description - can you please remove them? |
Member
|
Also currently there's a conflict, please resolve it too. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Elasticsearch Client Deprecation Warnings and Import Issues
Overview
This PR addresses several compatibility issues in the Elasticsearch integration code to improve reliability and eliminate deprecation warnings.
Changes Made
1. 🔧 Fixed Elasticsearch Client Deprecation Warning
Issue: The
bodyparameter ines_client.indices.create()is deprecated and will be removed in future versions.Solution: Updated the code to use separate parameters for settings and mappings:
2. ✅ Added Index Existence Check
Issue: Running the code multiple times would throw errors when trying to create an index that already exists.
Solution: Added a check to handle existing indices gracefully:
3. 🐛 Fixed tqdm Import Issue
Issue:
from tqdm.auto import tqdmwas causing widget display errors in some environments.Solution: Updated to use the standard tqdm import:
Benefits
Testing
Compatibility
This change maintains backward compatibility while adopting current best practices for the Elasticsearch Python client.