Requesting a pull to datastax:master from datastax:DSP-9944 #5

RussellSpitzer · 2016-10-31T18:26:01Z

Write a message for this pull request. The first block
of text is the title and the rest is description.

Changes:

cba7613 (Russell Spitzer, 3 days ago)
DSP-9944: Add Integration tests for Gradle and Maven

All tests should be run by Jenkins on PR

48111fb (Russell Spitzer, 4 days ago)
DSP-9944: Add SBT Integration Tests using Spark Embedded Cassandra

Adds test Resources directory matching the 1.6 version of the Spark
Cassandra Connector and compatiblet template files for C* 2.1,2.2, and 3

Dse and OSS build files modified so these tests can be run and can be run
from within an IDE.

Adds test Resources directory matching the 1.6 version of the Spark Cassandra Connector and compatiblet template files for C* 2.1,2.2, and 3 Dse and OSS build files modified so these tests can be run and can be run from within an IDE.

RussellSpitzer · 2016-10-31T18:29:24Z

test this please

RussellSpitzer · 2016-10-31T18:32:56Z

test this please

RussellSpitzer · 2016-10-31T18:35:00Z

test this please

RussellSpitzer · 2016-10-31T18:41:14Z

test-this-please

RussellSpitzer · 2016-10-31T18:41:19Z

test this please

RussellSpitzer · 2016-10-31T18:48:42Z

test this please

RussellSpitzer · 2016-10-31T18:51:29Z

test this please

ds-jenkins-builds · 2016-10-31T18:51:46Z

Build against Scala 2.11 finished with failure

RussellSpitzer · 2016-10-31T18:53:36Z

test this please

ds-jenkins-builds · 2016-10-31T18:53:54Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T18:59:38Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T19:00:29Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T19:05:26Z

Build against Scala 2.11 finished with failure

All tests should be run by Jenkins on PR

ds-jenkins-builds · 2016-10-31T19:16:54Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T19:17:08Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T19:17:11Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T19:18:13Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T19:20:35Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T19:27:57Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T19:39:28Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T19:42:48Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T20:08:34Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T20:28:49Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T20:50:06Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T21:25:30Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T21:48:52Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-10-31T22:05:08Z

Build against Scala 2.11 finished with success

jtgrabowski · 2016-11-02T09:12:46Z

Is this ready for review?

RussellSpitzer · 2016-11-02T18:34:16Z

@jtgrabowski I think this is good for now, Eventually we should get the SBT builds automatically running on Jenkins as well, at the moment I keep getting some bizarre random error. I would also appreciate if @bcantoni could pretend be a new user and make sure all the projects import correctly and there aren't any gotchas I left in there.

jtgrabowski · 2016-11-07T10:04:06Z

+1

bcantoni · 2016-11-07T17:24:11Z

I'll give it a "new user" check.

RussellSpitzer · 2016-11-07T17:26:14Z

Thanks @bcantoni :) I just assume your environment is closer to fresh than ours ;)

jtgrabowski · 2016-11-09T09:46:09Z

@RussellSpitzer build.gradle for scala has duplicated def connectorVersion = "1.6.0"

bcantoni · 2016-11-10T15:59:35Z

scala/gradle/dse/build.gradle

-// Please make sure that following dependencies have versions corresponding to the ones in your cluster.
-// Note that spark-cassandra-connector should be provided with '--packages' flag to spark-submit command.
+def scalaVersion = "2.10"
+def connectorVersion = "1.6.0"


duplicate definition

bcantoni · 2016-11-10T16:22:12Z

I've run through everything on a clean Ubuntu 14.04 VM and it looks good. Some feedback & questions:

Let's add a paragraph to the readme explaining about the new tests with embedded Cassandra; I don't think it needs to be super detailed, but at least summarize what we've added
It looks like tests are only added for the Scala projects? (that's fine if so, just want to make sure that was the intent)
At the end of scala/maven/oss, I always get an error when stopping embedded C*:

Run completed in 13 seconds, 418 milliseconds.
Total number of tests run: 3
Suites: completed 2, aborted 0
Tests: succeeded 3, failed 0, canceled 0, ignored 0, pending 0
All tests passed.
========-------- Stopping Embedded Cassandra at 10000 --------========
ERROR 15:52:11,337 com.datastax.driver.core.ControlConnection$1 (ControlConnection.java:151) - [Control connection] Cannot connect to any host, scheduling retry in 1000 milliseconds
 INFO 15:52:13,581 org.apache.spark.Logging$class (Logging.scala:58) - Disconnected from Cassandra cluster: Test Cluster 0
 INFO 15:52:13,583 org.apache.spark.Logging$class (Logging.scala:58) - Successfully executed shutdown hook: Clearing session cache for C* connector

RussellSpitzer · 2016-11-10T16:26:18Z

Sure i'll add that to the readme
I only did code for scala atm, it took a while so I"ll put off doing java for a while
I have no idea why that is... probably some race condition in the shutdown. I'm fine with just leaving it like that though ....

…ombinations

bcantoni · 2016-12-09T00:21:19Z

@RussellSpitzer I added a commit here to expand a bit on how to run the various examples, with updated class names. I think the only thing left would be if you could add a brief mention explaining the new tests with embedded Cassandra.

ds-jenkins-builds · 2016-12-09T18:31:14Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-12-10T14:31:49Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-12-20T23:19:23Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-12-20T23:25:17Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-12-20T23:26:07Z

Build against Scala 2.11 finished with failure

ds-jenkins-builds · 2016-12-20T23:51:00Z

Build against Scala 2.11 finished with success

ds-jenkins-builds · 2016-12-21T20:00:02Z

Build against Scala 2.11 finished with failure

RussellSpitzer force-pushed the DSP-9944 branch from cba7613 to 1c5e35d Compare October 31, 2016 18:46

DSP-9944: Add Integration tests for Gradle and Maven

17e6631

All tests should be run by Jenkins on PR

RussellSpitzer force-pushed the DSP-9944 branch from 1c5e35d to 17e6631 Compare October 31, 2016 19:11

bcantoni reviewed Nov 10, 2016

View reviewed changes

Readme edits to include new locations and classpath for all project c…

c30222d

…ombinations

DSP-9944: Update Dse Version to 5.0.4

7ef8d36

RussellSpitzer force-pushed the DSP-9944 branch from e7de475 to 7ef8d36 Compare December 20, 2016 23:59

RussellSpitzer merged commit 5bb3b3a into master Dec 21, 2016

RussellSpitzer deleted the DSP-9944 branch December 21, 2016 00:00

Requesting a pull to datastax:master from datastax:DSP-9944 #5

Requesting a pull to datastax:master from datastax:DSP-9944 #5

Uh oh!

Conversation

RussellSpitzer commented Oct 31, 2016

Uh oh!

RussellSpitzer commented Oct 31, 2016

Uh oh!

RussellSpitzer commented Oct 31, 2016

Uh oh!

RussellSpitzer commented Oct 31, 2016

Uh oh!

RussellSpitzer commented Oct 31, 2016

Uh oh!

RussellSpitzer commented Oct 31, 2016

Uh oh!

RussellSpitzer commented Oct 31, 2016

Uh oh!

RussellSpitzer commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

RussellSpitzer commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

ds-jenkins-builds commented Oct 31, 2016

Uh oh!

jtgrabowski commented Nov 2, 2016

Uh oh!

RussellSpitzer commented Nov 2, 2016

Uh oh!

jtgrabowski commented Nov 7, 2016

Uh oh!

bcantoni commented Nov 7, 2016

Uh oh!

RussellSpitzer commented Nov 7, 2016

Uh oh!

jtgrabowski commented Nov 9, 2016

Uh oh!

bcantoni Nov 10, 2016

Choose a reason for hiding this comment

Uh oh!

bcantoni commented Nov 10, 2016

Uh oh!

RussellSpitzer commented Nov 10, 2016

Uh oh!

bcantoni commented Dec 9, 2016