[Feature] sc-32608 Setup CLI telemetry#9
Merged
Conversation
Signed-off-by: Kent Huang <kent@infuseai.io>
Signed-off-by: Kent Huang <kent@infuseai.io>
kentwelcome
force-pushed
the
feature/sc-32608/recce-telemetry
branch
from
5318429 to
1bee87f
Compare
Signed-off-by: Kent Huang <kent@infuseai.io>
Signed-off-by: Kent Huang <kent@infuseai.io>
Signed-off-by: Kent Huang <kent@infuseai.io>
wcchang1115
reviewed
Nov 24, 2023
wcchang1115
reviewed
Nov 24, 2023
Signed-off-by: Kent Huang <kent@infuseai.io>
even-wei
added a commit
that referenced
this pull request
May 25, 2026
…-3411) Addresses PR #1376 review (Andy, Issues #8 and #9). Issue #8: `RunViewOss.tsx:111` described the Cancelled state as `run.status === "Cancelled"` only. Round 2 of this PR added the sticky-set gate (`useCanceledRuns.has(run_id)`), which the doc comment missed. Updated to describe both branches. Issue #9: `SS-5-result-pane-cancelled.png` was a duplicate of SS-3 — it showed an empty Query editor, not the "Cancelled in both header and body" state claimed in the PR description table. SS-2 (`SS-2-cancelled-chip-persists.png`) actually demonstrates the result-pane Cancelled invariant (Result tab shows status = "Cancelled" in the header AND a "Cancelled" body row). Dropping SS-5 to remove the contradiction; the PR description's SS-5 row should be struck and the invariant attributed to SS-2. Signed-off-by: even-wei <evenwei@infuseai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Setup Telemetry