Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mail alert params bug #774

Merged
merged 2 commits into from
Jul 26, 2022
Merged

Conversation

gaogao110
Copy link
Contributor

Purpose of the pull request

Fix mail alert params bug , Some parameters can be null

Brief change log

1.Delete some parameters not empty check , Used to adapt non-SSL connections

props.setProperty(EmailConstants.MAIL_SMTP_SSL_ENABLE, mailUseSSL);
props.setProperty(EmailConstants.MAIL_SMTP_SSL_TRUST, sslTrust);

if (StringUtils.isNotEmpty(EmailConstants.MAIL_SMTP_AUTH) && StringUtils.isNotEmpty(enableSmtpAuth)){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EmailConstants 内的属性key不需要判空

Copy link
Contributor

@Zzm0809 Zzm0809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zzm0809 Zzm0809 merged commit 392cd48 into DataLinkDC:dev Jul 26, 2022
@aiwenmo aiwenmo added the Bug Something isn't working label Aug 10, 2022
@aiwenmo aiwenmo added this to the 0.6.7 milestone Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants