Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] [Alert]Fix alert serializable #4023

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

zackyoungh
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@zackyoungh zackyoungh added the Bug Something isn't working label Dec 6, 2024
@zackyoungh zackyoungh added this to the 1.2.0 milestone Dec 6, 2024
@zackyoungh zackyoungh self-assigned this Dec 6, 2024
@zackyoungh zackyoungh marked this pull request as ready for review December 6, 2024 08:14
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit be98771 into DataLinkDC:dev Dec 6, 2024
18 checks passed
Zzm0809 pushed a commit to Zzm0809/dinky that referenced this pull request Dec 7, 2024
Co-authored-by: zackyoungh <zackyoungh@users.noreply.github.com>
@zackyoungh zackyoungh deleted the fix_alert_serializable branch December 21, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants