Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix][build] Fix Dinky backend CI workflow with Flink 1.20 #3891

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

yuxiqian
Copy link
Contributor

@yuxiqian yuxiqian commented Oct 28, 2024

Purpose of the pull request

This fixes Flink 1.20 packaging workflow isn't running as expected.

#3786 adds Flink 1.20 packaging profile, however it isn't running as expected, since 1.20 is interpreted as a floating value in YAML, and it decays to 1.2 at runtime.

CI workflows targeting Flink 1.20 are actually running with the following configuration:

Run ./mvnw -B clean install \
  ./mvnw -B clean install \
          -Dmaven.test.skip=false \
         -Dspotless.check.skip=true \
         -Denforcer.skip=false \
         -Dmaven.javadoc.skip=true \
         -P prod,flink-single-version,flink-1.2,maven-central \
         --no-snapshot-updates
  shell: /usr/bin/bash -e {0}
  env:
    MAVEN_OPTS: -Xmx2G -Xms2G
    JAVA_HOME: /opt/hostedtoolcache/Java_Adopt_jdk/8.0.432-6/x64
[INFO] Scanning for projects...

Brief change log

Changing flink matrix argument to '1.20' (explicitly as string) should fix this issue.

Verify this pull request

Ran backend CI tests in my own repo and it works as expected.

Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@zackyoungh zackyoungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zackyoungh zackyoungh added the Bug Something isn't working label Oct 30, 2024
@zackyoungh zackyoungh added this to the 1.2.0 milestone Oct 30, 2024
@zackyoungh zackyoungh merged commit 7bac212 into DataLinkDC:dev Oct 30, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants