[Feature] Add the functionality to automatically retrieve the latest highly available JobManager address #3392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing multiple job instances
…hly available JobManager address
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
…atest highly available JobManager address
gaoyan1998
approved these changes
Apr 18, 2024
| @@ -152,7 +162,7 @@ public static boolean refreshJob(JobInfoDetail jobInfoDetail, boolean needSave) | |||
| Long finishTime = TimeUtil.localDateTimeToLong(jobInstance.getFinishTime()); | |||
| long duration = Duration.between(jobInstance.getFinishTime(), LocalDateTime.now()) | |||
| .toMinutes(); | |||
| if (finishTime > 0 && duration < 1) { | |||
| if (finishTime > 0 && duration < 3) { | |||
There was a problem hiding this comment.
Maybe tt's not too long to change it to 3 minutes here.??? reconnect usually just tries again a few times.
Zzm0809
pushed a commit
to Zzm0809/dinky
that referenced
this pull request
May 6, 2024
…highly available JobManager address (DataLinkDC#3392) Co-authored-by: luoshangjie <luoshangjie@yfpharmacy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the functionality to automatically retrieve the latest highly available JobManager address
close #3085