-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix][Admin] Fix the problem of not being able to search using worknum #3388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing multiple job instances
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
April 12, 2024 07:21
Zzm0809
reviewed
Apr 12, 2024
@@ -15,6 +15,9 @@ | |||
<if test='param.nickname!=null and param.nickname!=""'> | |||
and a.nickname like "%${param.nickname}%" | |||
</if> | |||
<if test='param.worknum!=null and param.worknum!=""'> | |||
and a.worknum like "%${param.worknum}%" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
此方式会导致 sql 注入风险 请使用 concat('%',#{param.worknum},'%') ,并将昵称字段的查询修改为此种方式
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好的,谢谢老师指导
Zzm0809
approved these changes
Apr 12, 2024
Zzm0809
pushed a commit
to Zzm0809/dinky
that referenced
this pull request
May 6, 2024
DataLinkDC#3388) Co-authored-by: luoshangjie <luoshangjie@yfpharmacy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the problem of not being able to search using worknum