Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization] optimizing the construction of cdcsource out of order results in incorrect recovery from the savepoint #3349

Merged
merged 6 commits into from
Apr 28, 2024
Merged

[Optimization] optimizing the construction of cdcsource out of order results in incorrect recovery from the savepoint #3349

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7bc4400
optimizing the construction of cdcsource out of order results in inco…
Zzm0809 Apr 25, 2024
9249dd9
change to english
Zzm0809 Apr 26, 2024
d1e1603
Spotless Apply
Zzm0809 Apr 26, 2024
1092d56
optimizing the construction of cdcsource out of order results in inco…
Zzm0809 Apr 26, 2024
211c91a
optimizing the construction of cdcsource out of order results in inco…
Zzm0809 Apr 26, 2024
97bc429
optimizing the construction of cdcsource out of order results in inco…
Zzm0809 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
optimizing the construction of cdcsource out of order results in inco… 
…rrect recovery from the savepoint

Signed-off-by: Zzm0809 <934230207@qq.com>
  • Loading branch information
@Zzm0809
Zzm0809 committed Apr 26, 2024
commit 1092d56595d44c0d07b743844edbab983aa06ff7
11 changes: 6 additions & 5 deletions dinky-cdc/dinky-cdc-core/src/main/java/org/dinky/cdc/AbstractSinkBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,8 +324,6 @@ protected void buildColumn(List<String> columnNameList, List<LogicalType> column

public LogicalType getLogicalType(Column column) {
switch (column.getJavaType()) {
case STRING:
return new VarCharType();
case BOOLEAN:
case JAVA_LANG_BOOLEAN:
return new BooleanType();
Expand Down Expand Up @@ -358,9 +356,11 @@ public LogicalType getLogicalType(Column column) {
return new DateType();
case TIME:
case LOCALTIME:
return column.getPrecision() != null
? new TimeType(column.isNullable(), column.getPrecision())
: new TimeType();
if (column.getPrecision() != null) {
return new TimeType(column.isNullable(), column.getPrecision());
} else {
return new TimeType();
}
case LOCAL_DATETIME:
case TIMESTAMP:
if (column.getLength() != null) {
Expand All @@ -370,6 +370,7 @@ public LogicalType getLogicalType(Column column) {
}
case BYTES:
return new VarBinaryType(Integer.MAX_VALUE);
case STRING:
default:
return new VarCharType();
}
Expand Down
Loading