Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] move alert rule to register center's alert #3294

Merged
merged 3 commits into from
May 7, 2024

Conversation

Zzm0809
Copy link
Contributor

@Zzm0809 Zzm0809 commented Mar 15, 2024

Purpose of the pull request

Brief change log

  • 重构: 将告警策略从配置中心移动至注册中心的告警路由下

note: 有数据库 dml 变更

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@Zzm0809 Zzm0809 added this to the 1.1.0 milestone Mar 15, 2024
@Zzm0809 Zzm0809 marked this pull request as draft March 15, 2024 07:47
@Zzm0809 Zzm0809 marked this pull request as ready for review March 25, 2024 14:14
@Zzm0809 Zzm0809 marked this pull request as draft April 2, 2024 02:04
@Zzm0809 Zzm0809 marked this pull request as ready for review April 17, 2024 07:00
@Zzm0809 Zzm0809 force-pushed the move-alert-rule-2-registercenter branch 2 times, most recently from 441710d to 92b5b77 Compare May 6, 2024 15:01
Zzm0809 and others added 2 commits May 6, 2024 23:05
Signed-off-by: Zzm0809 <934230207@qq.com>
Copy link
Contributor

@gaoyan1998 gaoyan1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gaoyan1998 gaoyan1998 merged commit 28f2704 into DataLinkDC:dev May 7, 2024
15 checks passed
@Zzm0809 Zzm0809 deleted the move-alert-rule-2-registercenter branch May 20, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants