Skip to content

Conversation

Zzm0809
Copy link
Contributor

@Zzm0809 Zzm0809 commented Mar 9, 2024

Purpose of the pull request

close #3182

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@Zzm0809 Zzm0809 added the Bug Something isn't working label Mar 9, 2024
@Zzm0809 Zzm0809 added this to the 1.0.1 milestone Mar 9, 2024
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit 53e72f1 into DataLinkDC:dev Mar 9, 2024
gaoyan1998 pushed a commit to gaoyan1998/dinky that referenced this pull request Mar 19, 2024
Co-authored-by: Zzm0809 <Zzm0809@users.noreply.github.com>
@Zzm0809 Zzm0809 deleted the fix-modal-cannot-close branch April 15, 2024 09:20
leechor pushed a commit that referenced this pull request Jul 17, 2024
Co-authored-by: Zzm0809 <Zzm0809@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Optimization] [web] The close button doesn't work in two places.UDF template edit page and Git project build page
3 participants