Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix][Web] Fix web page show #3138

Merged
merged 2 commits into from
Feb 4, 2024
Merged

Conversation

zackyoungh
Copy link
Contributor

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@zackyoungh zackyoungh added the Bug Something isn't working label Feb 4, 2024
@zackyoungh zackyoungh added this to the 1.0.0 milestone Feb 4, 2024
@zackyoungh zackyoungh self-assigned this Feb 4, 2024
Copy link
Contributor

@aiwenmo aiwenmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aiwenmo aiwenmo merged commit cfcaf43 into DataLinkDC:dev Feb 4, 2024
15 checks passed
gaoyan1998 pushed a commit to gaoyan1998/dinky that referenced this pull request Mar 19, 2024
Co-authored-by: zackyoungh <zackyoungh@users.noreply.github.com>
@zackyoungh zackyoungh deleted the fix_web_page_show branch November 21, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants